Pin bin/ci's tool versions in .mise.toml - #649
Open
jeremy wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Pins local development tools in mise so bin/ci works in fresh worktrees.
Changes:
- Pins actionlint, ShellCheck, PowerShell, and zizmor.
- Documents CI synchronization expectations.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| powershell = "7.6.5" | ||
| # Keep roughly in sync with .github/workflows/test.yml zizmor-action pin, | ||
| # which pins the action version (v0.6.2), not a zizmor binary version. | ||
| zizmor = "1.28.0" |
bin/ci fails cold in a fresh worktree: mise shims for actionlint, shellcheck, and pwsh exist machine-wide but no version is pinned for this project, so each one dies with "No version is set for shim". shellcheck isn't even invoked by the repo directly — actionlint shells out to it to lint workflow run: blocks, so the broken shim takes actionlint down with it. zizmor is worse than unpinned: make lint-actions hard-fails without it and make tools can't install it (brew/pacman only). Pin all four in [tools] so mise install makes bin/ci self-sufficient: * actionlint 1.7.12 — matches the .github/workflows/test.yml action pin * shellcheck 0.11.0 — actionlint's dependency; CI uses the runner's preinstall * powershell 7.6.5 — no CI pin to mirror (runners preinstall pwsh); turns the three fail-closed-in-CI installer.bats pwsh tests into locally-running tests * zizmor 1.29.0 — pinned in the workflow too: zizmor-action's version input defaults to "latest", so the SHA-pinned action still selected a floating zizmor release. Now the action and mise pin the same binary version. Each pin carries a sync comment mirroring the existing goreleaser convention.
jeremy
force-pushed
the
mise-pin-ci-tools
branch
from
August 22, 2026 08:35
fbd6848 to
10a4f19
Compare
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
Comment on lines
+98
to
+100
| # The action's default version floats to the latest zizmor release. | ||
| # Keep in sync with the .mise.toml zizmor pin. | ||
| version: "1.29.0" |
| powershell = "7.6.5" | ||
| # Keep in sync with the zizmor-action `version:` input in | ||
| # .github/workflows/test.yml (the action's default floats to latest). | ||
| zizmor = "1.29.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/cifails cold in a fresh worktree. mise shims for actionlint, shellcheck, and pwsh exist machine-wide but the project pins no versions, so each shim dies with "No version is set for shim". shellcheck isn't even a repo tool — actionlint shells out to it to lint workflowrun:blocks, so its broken shim takes actionlint down with it. And zizmor is a fourth gap:make lint-actionshard-fails without it, andmake toolscan't install it (brew/pacman only).This pins all four in
[tools]somise installmakesbin/ciself-sufficient:rhysd/actionlintpin in.github/workflows/test.ymlinstaller.batspwsh tests now run locally instead of skippingversion:input in the workflow — its default floats to latest, so the SHA-pinned action still selected a floating zizmor releaseEach pin carries a sync comment mirroring the existing goreleaser convention. No Makefile changes. The workflow's zizmor step gains
version: "1.29.0"so CI and local runs use the same binary.Verified:
mise installthen a fullbin/cirun in a fresh worktree, green with noMISE_*_VERSIONenv workaround — actionlint and zizmor 1.29.0 ran, and the pwsh installer tests executed rather than skipping.