Fix search to be cross-board by default

[waynemsmith]

Summary

• search called defaultBoard() which injected the configured default board into every query, silently scoping results to a single board
• This made --tag and --assignee filters appear broken when matching cards existed on other boards
• Fix: only add board_ids[] when --board is explicitly passed

Closes #113

Test plan

• go test ./internal/commands/ -run TestSearch — all 6 existing tests pass
• Manual: fizzy search "" --tag TAG_ID --all returns cards across all boards
• Manual: fizzy search "query" --board BOARD_ID still scopes correctly when explicit

🤖 Generated with Claude Code

---

Summary by cubic

Search is now cross-board by default. We removed the implicit default board so results include cards from all boards unless --board is set.

• Bug Fixes
  • Added tests to ensure no implicit board scope and to assert call count before indexing; removed redundant searchBoard assignments in tests.
  • Confirmed --tag and --assignee filters work cross-board and do not inject board_ids[] unless --board is passed.

^{Written for commit c9c2d91. Summary will update on new commits.}

[Copilot]

Pull request overview

This PR updates fizzy search to be cross-board by default by no longer auto-injecting the configured default board into every search request, addressing #113 where tag/assignee filters appeared broken when matching cards were on other boards.

Changes:

• Stop calling defaultBoard() from search so searches are no longer silently scoped to the configured default board.
• Only include board_ids[] in the API request when --board is explicitly provided.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

No issues found across 1 file

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[robzolkos]

@waynemsmith - this is looking good - thanks for taking the time to fix. Could you please add a test covering the exact reported --tag / --assignee case from the issue. The root-cause regression is covered now, but adding one of those cases could make the user-facing behavior a little more explicit.

[waynemsmith]

@robzolkos Good call — added two tests in 36b2690:

• "tag filter works cross-board with default board set" — sets cfg.Board, searches with --tag, asserts tag_ids[] present but board_ids[] absent
• "assignee filter works cross-board with default board set" — same pattern with --assignee

Both confirm the user-facing behavior from the issue.

[github-actions]

⚠️ Potential breaking changes detected:

• The default behavior of the 'search' command has changed: previously, the search was scoped to a default board; now, searches are cross-board by default unless explicitly scoped using the --board flag. This constitutes a breaking change as scripts relying on the old behavior (e.g., assuming searches are scoped by default) might not work correctly without modification.

Review carefully before merging. Consider a major version bump.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[robzolkos]

Thanks @waynemsmith