Add margin to details inside popup styles #2240
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow focus indicator to display in full when navigating with the keyboard (using TAB)
Contributor
|
Thanks, @vixen24! Instead of adjusting the margins, it would be preferable to bump the z-index when an element has focus. That way the spacing is never dependent on the style/weight of the focus ring. Something like this: .popup__btn {
&:focus-visible {
z-index: 1;
}
} |
Remove margin-block-start from details in popup styles and add focus-visible style to popup item.
Contributor
Author
|
@andyra Thanks for the feedback! I have applied your suggestion to bump z-index on :focus-visible rather than adjusting margins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow focus indicator to display in full when navigating with the keyboard (using TAB)
Before
After
