feat(bindings): automatically unbind defaults on override#6118
Open
felixzsh wants to merge 2 commits into
Open
feat(bindings): automatically unbind defaults on override#6118felixzsh wants to merge 2 commits into
felixzsh wants to merge 2 commits into
Conversation
without this, the user could define the same default bindings and make duplicated actions on the same keybinding, this overrides default bindings in favor of user config bindings
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Omarchy’s Hyprland Lua binding helper so user-defined keybindings replace (rather than accumulate alongside) default bindings, aiming to prevent duplicated actions when a user redefines a default key.
Changes:
- Track previously bound key strings inside
o.bind()and automaticallyhl.unbind()before rebinding. - Prefer the most recently declared binding for a given key, enabling user overrides to take effect without manual unbind steps.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
felixzsh
marked this pull request as draft
June 21, 2026 16:07
felixzsh
marked this pull request as ready for review
June 21, 2026 16:31
felixzsh
changed the title
felixzsh
changed the title
felixzsh
marked this pull request as draft
June 21, 2026 17:02
Restrict override to launch-command bindings so tiling duplicates (ALT+TAB → cycle_next + bring_to_top) and multi-event bindings (press + release on same key) are preserved.
felixzsh
force-pushed
the
feat/o-bind-override-semantics
branch
from
June 21, 2026 17:15
9c50889 to
d1048f9
Compare
felixzsh
marked this pull request as ready for review
June 21, 2026 17:16
felixzsh
changed the title
felixzsh
changed the title
felixzsh
changed the title
felixzsh
changed the title
felixzsh
changed the title
Contributor
Author
|
@dhh could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with this, there is no need to explicitly unbind when overriding