Move toggle config source before user overrides in hyprland.conf#6201
Closed
sridhar-3009 wants to merge 1 commit into
Closed
Move toggle config source before user overrides in hyprland.conf#6201sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
The toggle conf glob was loaded after the user's custom files (looknfeel.conf, etc.), so any Hyprland variable set by a toggle — like single_window_aspect_ratio from the tiling toggle — silently won over whatever the user had in their own looknfeel.conf. Move the toggle source line to be after the Omarchy defaults but before the user's custom files. The new order is: Omarchy defaults → current theme → toggle flags → user overrides User overrides always win, which is the expected mental model. Fixes basecamp#6068.
Contributor
There was a problem hiding this comment.
Pull request overview
Moves Hyprland toggle config sourcing earlier in the default hyprland.conf so Omarchy toggles act as feature flags while user config files remain the final authority (user overrides win).
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Reorders
source = ~/.local/state/omarchy/toggles/hypr/*.confto load after defaults/theme but before user override files inconfig/hypr/hyprland.conf.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+17
| # Toggle config flags dynamically (loaded before user overrides so that | ||
| # ~/.config/hypr/looknfeel.conf and friends can still take precedence) | ||
| source = ~/.local/state/omarchy/toggles/hypr/*.conf |
Member
|
Closing in favor of the Lua-compatible toggle load-order fix in #6116. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Toggle conf files (
~/.local/state/omarchy/toggles/hypr/*.conf) are loaded after the user's custom files (looknfeel.conf, etc.), so any Hyprland variable set by a toggle — likesingle_window_aspect_ratiofrom the tiling toggle — silently overrides whatever the user put in their ownlooknfeel.conf. The only workaround today is to sourcelooknfeel.confagain at the very bottom ofhyprland.conf.Reported in #6068.
Fix
Move the toggle
sourceglob to be between the Omarchy defaults and the user's custom files:User overrides always win, which is the expected mental model: toggles express Omarchy feature flags, not unoverrideable system policy.