Conversation
| // Validate the envelope structure | ||
| if (parsed.schema_version !== 1) { | ||
| throw new Error('Unsupported schema_version'); | ||
| } |
There was a problem hiding this comment.
Cleanup: the new "Contract fixtures and validator" section is a near-verbatim duplicate of the paragraph already present ~25 lines above it in the same file (both describe CI validating fixtures against packaged schemas via a Python validator and a Node.js reader). Consider merging to avoid having to update the same claim in two places.
There was a problem hiding this comment.
Fixed — the duplicate paragraph is gone in the latest commit (docs: remove duplicate contract guidance). Thanks!
| is unavailable or fails. | ||
|
|
||
| ## Optional output-format dependencies | ||
|
|
There was a problem hiding this comment.
Doc accuracy: this table says a missing PyYAML surfaces a raw ImportError: No module named 'yaml', but the code never lets that propagate — require_yaml() (lib/python/base_cli/_dependencies.py) catches ImportError and re-raises a RuntimeError with an actionable install hint, which the caller wraps into OutputFormatError. A user grepping logs for the documented string won't find it, and the doc omits the actual (more useful) message the CLI produces.
There was a problem hiding this comment.
Fixed — the table now shows the actual wrapped message (OutputFormatError: PyYAML is required...) instead of the raw ImportError text. Thanks!
|
Blocking: this PR currently fails the This repo's branch-naming policy ( i.e. Since this PR's commits reference issues #345 and #346, renaming the branch to something like |
|
Hey @bogusdeck, thank you for taking this on and for the careful work here — the table and the Node validation examples are clear and follow the issues' acceptance criteria well. Closing this one only because of timing, not quality: while this PR was open, #345 and #346 ended up getting addressed independently in #352 and #353, which merged the same day. Those landed as dedicated pages ( I'll close this PR rather than merge duplicate content on top of what's already there. If you're up for it, I'd genuinely welcome you picking up another open issue — your approach here (matching the acceptance criteria, keeping the diff focused) was solid. Thanks again for contributing! |
Summary
This PR addresses two documentation issues:
Changes
docs/output-contracts.mdyamlandrich.docs/json-contracts.mdJSON.parse.Notes
Both changes are documentation-only and follow the acceptance criteria defined in their respective issues.