fix #4339 【システム】機能要望：BcAdminFormHelper で type='time' に対応#4418
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、管理画面用フォームヘルパー BcAdminFormHelper::control() において type='time' を指定した際に、他のテキスト系入力と同様のスタイル（bca-textbox 系）で描画できるようにする対応です。既存の switch 分岐に time を追加し、期待する出力になることをユニットテストで担保しています。
Changes:
BcAdminFormHelper::control()のテキスト系入力の分岐にtimeを追加type='time'指定時の出力が期待通りになることをテストケースに追加
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/baser-core/src/View/Helper/BcAdminFormHelper.php | control() の type 判定に time を追加し、テキストボックス系のCSS/テンプレート変数が適用されるように変更 |
| plugins/baser-core/tests/TestCase/View/Helper/BcAdminFormHelperTest.php | type='time' の control() がオプション展開後の期待値と一致することを確認するテストを追加 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。