fix #2712 【カスタムコンテンツ】プレビュー機能で入力項目が隠れてしまう件を修正#4419
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
カスタムコンテンツのプレビュー表示(画面下部に固定される #CustomFieldPreview / #CustomLinkPreview)が高さを取りすぎて入力項目を覆ってしまう問題(#2712)に対応し、プレビュー領域を一定高さに制限して内部スクロールできるようにするPRです。
Changes:
#CustomFieldPreview/#CustomLinkPreviewにmax-height: 45vhを追加し、表示が大きくなりすぎないよう制限- 同2要素に
overflow-y: auto/overflow-x: hiddenを追加し、プレビュー領域内でスクロール可能に変更 - 生成済みCSS(
webroot)とSCSSソース(src)の両方へ同内容を反映
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/bc-admin-third/webroot/css/admin/style.css | プレビュー固定領域に最大高さとスクロールを付与し、入力欄が隠れにくい表示へ調整 |
| plugins/bc-admin-third/src/css/components/_custom-field.scss | 同調整をSCSSソース側にも反映(ビルド生成物との差分が出ないよう整合) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします!