Use set-backed tracking for faster duplicate argument checks#124
Open
Stephen0512 wants to merge 1 commit intobastikr:masterfrom
Open
Use set-backed tracking for faster duplicate argument checks#124Stephen0512 wants to merge 1 commit intobastikr:masterfrom
Stephen0512 wants to merge 1 commit intobastikr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves argument deduplication by introducing a set for faster membership checks while still maintaining a list to preserve the original argument order.
The previous implementation relied solely on a list to track seen arguments, which preserved order but required repeated O(n) membership checks. Using a set enables O(1) average-time lookups without changing existing behavior.
The issue was identified during an ongoing research project.