Repository navigation
Fix health check with lazy.nvim, handle null playlists, preserve C-p for navigation - #3
Open
rosscondie wants to merge 3 commits into
Open
rosscondie wants to merge 3 commits into
rosscondie wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Trash sick plugin, thanks for building it I heard about it on the podcast btw.
It wasn't working out of the box with LazyVim for me, so I dug in a bit and noticed a couple of small issues. Also added
C-pfor navigation again as it collided with Telescope's default for previous, happy to drop that part if it's too much but the null check and health check fixes would be useful I think.1. Fix health check discovery when plugin is lazy-loaded
README lazy.nvim example used
cmd = { "Jam" }andlazy=trueeven withLazyVim.defaults.lazy=false.lua/jam/health.luastays off&rtpuntil:Jamloads, so:checkhealth jamshowsNo healthcheck foundfor every LazyVim user following the docs (while:Jam healthworks). Removedcmdfrom docs so:checkhealth jamis discoverable eagerly.2. Handle null playlist items returned by Spotify search
GET /search?q=Beatles&type=playlistreturns[null,null,{...}]for restricted playlists ->vim.NIL(truthy) ->providers/spotify.lua:51 normalizecrashesattempt to index userdata. Guardednormalizeand all buckets (search,album_tracks,artist_top_tracks,show_episodes,playlist_items,now_playing) to skipvim.NIL. UnfilteredBeatlesnowOK 56vs crash before.3. Preserve C-p for navigation and remap pause to M-p
ui/picker.luamapped<C-p>-> pause, shadowingtelescope/mappings.lua:145C-p = move_selection_previous. Normal vim users expectC-p/C-nto move. Remapped pause to<M-p>(Alt-p) in both pickers and updatedREADME.md/doc/jam.txt. RequiresOption as Altin Kitty/WezTerm/iTerm on macOS.