refactor: Migrate test_toolchain_deps.sh and test_twitter_scrooge.sh to Bazel - #1908
Draft
bor-p-s wants to merge 2 commits into
Draft
refactor: Migrate test_toolchain_deps.sh and test_twitter_scrooge.sh to Bazel#1908bor-p-s wants to merge 2 commits into
bor-p-s wants to merge 2 commits into
Conversation
bor-p-s
force-pushed
the
bor-p-s/nested-bazel-toolchain-deps-scrooge
branch
from
August 7, 2026 14:29
c909a03 to
4978c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates test_toolchain_deps.sh to 4 expect_build_success_test targets in
test/semanticdb (one per Scala version, building
//scala/private/toolchain_deps:semanticdb), and test_twitter_scrooge.sh to one
in test/src/main/scala/scalarules/test/twitter_scrooge, building that
package's wildcard under JDK 11. Continues #1900/#1882/#1881/#1880/#1864.
toolchain_deps is production code outside test/semanticdb, so the macro's
package-scoped glob doesn't track it for staleness; each test also depends on
the built target directly (see comment in test/semanticdb/BUILD).
The scrooge target already builds under the repo's default
java_runtime_version=17, so this test confirms it also builds under 11 rather
than only under 11 - dropping the JDK 11 flags does not turn it red.
Motivation
Deletes both scripts and their test_rules_scala.sh lines.
test/shell/scala_versions.sh stays; test_version.sh still uses it.
Release impact: tests only. Adds 4 more serialized (exclusive) nested-bazel
tests; worth checking the real CI step-time delta (locally, warm cache, they
run ~5-6s each).