Basic test case of protobuf codegen / integration #411
Open
jerrymarino wants to merge 3 commits intomasterfrom
Open
Basic test case of protobuf codegen / integration #411jerrymarino wants to merge 3 commits intomasterfrom
jerrymarino wants to merge 3 commits intomasterfrom
Conversation
Add an example where a proto imports another proto. This addtionally exports the Protobuf runtime as a framework into rules_ios. proto_map.txt - this file is used to map protobuf imports to framework names in rules_ios
jerrymarino
force-pushed
the
jmarino/protos_test_case
branch
from
5f310d9 to
66d1b95
Compare
dnkoutso
approved these changes
Feb 8, 2022
thiagohmcruz
approved these changes
Feb 8, 2022
Contributor
Author
|
Debugging of these code-generated sources is broken because the dep on external protobuf -see linked issue for mitigation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds usage of code generated protos using
rules_proto_grpcNext, we'll need to ensure the generated code is aligned with import statements