feat: Support custom Error Prone plugin injection in JavaBuilder#30140
Open
JonathanPerry651 wants to merge 3 commits into
Open
feat: Support custom Error Prone plugin injection in JavaBuilder#30140JonathanPerry651 wants to merge 3 commits into
JonathanPerry651 wants to merge 3 commits into
Conversation
github-actions
Bot
added
team-Rules-Java
JonathanPerry651
force-pushed
the
custom-javabuilder-support
branch
from
a184391 to
73c305f
Compare
JonathanPerry651
force-pushed
the
custom-javabuilder-support
branch
2 times, most recently
from
8cde081 to
15f6c4e
Compare
JonathanPerry651
force-pushed
the
custom-javabuilder-support
branch
from
15f6c4e to
bd402ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors Bazel's
JavaBuildercompilation wrapper to dynamically load Error Prone and its plugins at runtime viajava.util.ServiceLoaderrather than linking them at compile-time.To support Javac's classloader masking/isolation,
ClassloaderMaskingFileManagerdynamically scans for registeredBugCheckerservices on the classpath and automatically whitelists and delegates their package prefixes to the parent classloader. This ensures custom checkers and any helper/utility classes packaged alongside them load successfully without version conflict issues or classloader blocks.Motivation
Injecting custom Error Prone plugins (or using a customized version of Error Prone) in Bazel was previously extremely difficult because
JavaBuildercompile-time linked the bundled Error Prone core and enforced a strict, whitelisted classloader masking filter that blocked custom plugin packages. Decoupling this allows users to seamlessly define and run custom checkers in their Java toolchains.This PR implements the core JavaBuilder runtime loading changes for Bazel Issue #29910.
Note: This PR depends on the rules_java Starlark macro changes in bazelbuild/rules_java#364.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None