Skip to content

Add generate_linkmap attribute support - #2976

Merged
brentleyjones merged 1 commit into
mainfrom
bj/linkmap-attr-starlark-coverage
Oct 13, 2026
Merged

brentleyjones merged 1 commit into
mainfrom
bj/linkmap-attr-starlark-coverage

Conversation

@brentleyjones

@brentleyjones brentleyjones commented May 20, 2026 •

Copy link
Copy Markdown
Collaborator

Add a per-target generate_linkmap attribute to Apple binary rules while preserving --objc_generate_linkmap as a global override.

Validation:

  • Regenerated documentation with bazel run //doc:update; all 15 documentation checks pass.
  • All 11 targeted linkmap analysis tests pass, covering the per-target attribute, linker arguments, output groups, the global flag, and XCFrameworks.
  • Buildifier formatting and lint checks pass.

@brentleyjones
brentleyjones force-pushed the bj/linkmap-attr-starlark-coverage branch 2 times, most recently from b63b5a3 to cb760f6 Compare May 20, 2026 21:09
@brentleyjones brentleyjones changed the title Add linkmap attr starlark coverage Add generate_linkmap attribute support May 20, 2026
@brentleyjones
brentleyjones force-pushed the bj/linkmap-attr-starlark-coverage branch 2 times, most recently from 4cc3efd to f94efd7 Compare May 21, 2026 13:14
@brentleyjones
brentleyjones marked this pull request as ready for review May 21, 2026 17:02
@brentleyjones
brentleyjones force-pushed the bj/linkmap-attr-starlark-coverage branch from f94efd7 to d18b451 Compare October 13, 2026 14:51
@brentleyjones brentleyjones added AI Generated Changes prepared with AI assistance and removed AI Generated Changes prepared with AI assistance labels Oct 13, 2026
@brentleyjones
brentleyjones enabled auto-merge (squash) October 13, 2026 14:52
@brentleyjones
brentleyjones merged commit 4542e7b into main Oct 13, 2026
14 checks passed
@brentleyjones
brentleyjones deleted the bj/linkmap-attr-starlark-coverage branch October 13, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants