Repository navigation
Conversation
A `.docc` catalog in the `data` of a library is only used by `docc_archive` to build documentation, but was also copied into the bundles depending on the library as unprocessed resources. When the catalog's files are listed individually, they're even flattened into the root of the bundle, where they can conflict with other resources. Skip files in `.docc` catalogs when bucketizing resources, matching Xcode, which never copies documentation catalogs into products. Assisted-by: Claude <noreply@anthropic.com>
louwers
requested review from
aaronsky,
adincebic,
brentleyjones,
keith and
luispadron
as code owners
October 11, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
.docccatalog in thedataof a library is only used bydocc_archiveto build documentation, but it is also copied into every bundle that depends on the library as unprocessed resources. For example, theHelloWorldSwiftexample app currently shipsHelloWorldSwift.app/HelloWorldSwift.docc/README.md.When a catalog's files are listed individually (e.g. with a
glob), they are also flattened into the root of the bundle. Thebasic_framework_with_docc_bundletest fixture currently contains bothbasic.docc/README.mdandREADME.md, which can conflict with other resources.This skips files in
.docccatalogs when bucketizing resources, matching Xcode, which never copies documentation catalogs into products.docc_archivereads the catalog fromdatathrough its own aspect, so it is not affected.Testing
docc_ios_framework_does_not_contain_docc_bundle, which fails without this change.bazel test //test/starlark_tests:doccpasses.🤖 Generated with Claude Code