Skip to content

Fixed: Python bindings #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juniorep merged 2 commits into from
Jul 17, 2026
Merged

Fixed: Python bindings #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8206904
update: version
bbalouki Jul 17, 2026
c27bd3a
updates
bbalouki Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

## Checklist

- [ ] Code follows the style in [CLAUDE](../CLAUDE.md) (`snake_case`, `PascalCase` types, `m_` members, trailing return types, etc.).
- [ ] Code follows the style (`snake_case`, `PascalCase` types, `m_` members, trailing return types, etc.).
- [ ] `clang-format` and `clang-tidy` pass locally.
- [ ] Tests were added or updated under `tests/` and `ctest` passes.
- [ ] Public API changes are documented with Doxygen `///` comments.
Expand Down
21 changes: 20 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.6.3] - 2026-07-17

### Fixed

- Python bindings (`ITCH_BUILD_PYTHON=ON`) failed to configure under newer
CMake releases because pybind11 defaulted to its legacy
`FindPythonInterp`-based discovery; `python/CMakeLists.txt` now forces the
modern `FindPython` path via `PYBIND11_FINDPYTHON`.
- vcpkg `builtin-baseline` bumped past a pinned `benchmark` port revision
whose portfile passed an invalid `-Werror=old-style-cast` CMake argument,
which broke any fresh build of that dependency.
- CI: pinned Windows runners off the floating `windows-latest` label (which
moved to a newer toolchain vcpkg's `benchmark` port doesn't yet build
under) and hardened the GitHub Actions vcpkg/CMake build caches (keyed on
the concrete runner label, no unsafe `restore-keys` fallback) so a
toolchain or dependency change can't silently restore an incompatible
cached build.

## [1.6.2] - 2026-07-11

### Fixed
Expand Down Expand Up @@ -79,7 +97,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`std::variant`, plus `std::vector`- and callback-based parsing entry points
with optional message-type filtering.

[Unreleased]: https://github.com/bbalouki/itchcpp/compare/v1.6.2...HEAD
[Unreleased]: https://github.com/bbalouki/itchcpp/compare/v1.6.3...HEAD
[1.6.3]: https://github.com/bbalouki/itchcpp/compare/v1.6.2...v1.6.3
[1.6.2]: https://github.com/bbalouki/itchcpp/compare/v1.6.1...v1.6.2
[1.6.1]: https://github.com/bbalouki/itchcpp/compare/v1.6.0...v1.6.1
[1.6.0]: https://github.com/bbalouki/itchcpp/compare/v1.1.0...v1.6.0
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Optional features are off by default and enabled with:

## Code style

- Follow the rules in [CLAUDE](CLAUDE.md): `snake_case` functions/variables,
- `snake_case` functions/variables,
`PascalCase` types, `m_` private members, `SCREAMING_SNAKE_CASE` constants,
symbols at least three characters, trailing return types, brace initialization,
and `std::print`/`std::format` for output.
Expand Down
2 changes: 1 addition & 1 deletion VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.6.2
1.6.3
Loading