Repository navigation
CI: run credo, dialyzer, hex audit, argus and tests - #36
Merged
Merged
Conversation
Tests, credo and dialyzer already ran in CI. Add a Hex audit job (hex.audit plus deps.unlock --check-unused) and an Argus job on ubuntu-22.04 with Souffle from its PPA, and add argus_beam as a dev/test dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UmkxCtMk3Y8vf2b42ZyVTu
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Argus gate currently fails on two known findings, leaving the PR’s CI permanently red.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Hex dependency auditing and Argus static analysis to CI.
Changes:
- Adds dedicated Hex audit and Argus jobs.
- Adds and locks the Argus dependency.
- Configures Soufflé and isolated Argus caching.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds audit and Argus CI gates. |
mix.exs |
Adds argus_beam. |
mix.lock |
Locks Argus and transitive dependencies. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| mix-argus-${{ steps.beam.outputs.otp-version }}-${{ steps.beam.outputs.elixir-version }}- | ||
|
|
||
| - run: mix deps.get --check-locked | ||
| - run: mix argus --fail-above 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #35.
What changed
CI already ran the test suite,
mix credo --strictandmix dialyzer. This PR adds the two missing gates, using the same setup-beam versions, action versions and cache layout as the existing jobs:mix deps.get --check-locked, thenmix deps.unlock --check-unusedandmix hex.audit. This job has no build cache because it doesn't compile anything.ubuntu-22.04, because Souffle's PPA package needs libffi7 and Ubuntu 24.04 doesn't ship it. It installs Souffle from the PPA, then runsmix deps.get --check-lockedandmix argus --fail-above 0. Its deps/_build cache uses its ownmix-argus-key so it doesn't share build output with the ubuntu-latest jobs.mix.exs: adds{:argus_beam, "~> 0.20", only: [:dev, :test], runtime: false}, which locks argus_beam 0.20.1 and its deps.:argusis not added tocompilers:, so it stays a separate CI gate.The repo already has a
.credo.exs, so this PR doesn't touch it.Validation (local)
mix compile --warnings-as-errors,mix format --check-formatted: passmix test: 4 doctests, 418 tests, 0 failuresmix credo --strict: no issuesmix dialyzer: passedmix deps.unlock --check-unused,mix hex.audit: cleanmix argus --fail-above 0: fails with 2 findings in existing code: an unidentified keepalive timer message inEspex.Connection.arm_keepalive/2, and a barespawninEspex.Connection.notify_connections_changed/1. This PR only adds the gate, as intended. The fixes are in the next PR in the stack ("Fix issues raised by the new CI gates"), so the Argus job is expected to be red on this PR alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01UmkxCtMk3Y8vf2b42ZyVTu
Generated by Claude Code