Repository navigation
CI: add Sobelow and a Compile · Format job - #40
Merged
Merged
Conversation
Move compile --warnings-as-errors out of the Test job into a parallel Compile · Format job that also checks formatting, and add a Sobelow job (medium threshold) with sobelow as a dev/test dep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UmkxCtMk3Y8vf2b42ZyVTu
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency and workflow changes are consistent, scoped, and correctly implement the stated CI checks.
Review effort: Balanced
Findings: None
What changed in this PR
Adds required Sobelow security scanning and compile/format validation to CI.
Changes:
- Adds a parallel Compile · Format job.
- Adds Sobelow dependency and CI job.
- Moves warnings-as-errors compilation out of Test.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds Compile · Format and Sobelow jobs. |
mix.exs |
Adds Sobelow as a development/test dependency. |
mix.lock |
Locks Sobelow 0.16.0. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Without --private, Sobelow calls out to a version service on every run, adding latency and making the security job depend on that service's availability. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UmkxCtMk3Y8vf2b42ZyVTu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds the two CI jobs every repo is required to have, both running in parallel with the existing jobs. This PR targets
maindirectly; it is not stacked on another PR.Jobs before: Test (deps.get,
compile --warnings-as-errors,mix test), Credo, Dialyzer, Hex audit, ArgusJobs after: Test (
mix testonly), Compile · Format (new), Credo, Dialyzer, Sobelow (new), Hex audit, Arguscompile-format): runsmix compile --warnings-as-errorsand thenmix format --check-formatted. The compile step moved here from the Test job. Before this PR, CI did not check formatting at all. The job uses the same setup-beam/cache action versions and the sameMIX_ENV: testas Test, with its own cache keymix-compile-*.sobelow): runsmix sobelow --skip --exit --threshold medium, with its own cache keymix-sobelow-*.mix.exsgains{:sobelow, "~> 0.14", only: [:dev, :test], runtime: false}next to credo and dialyxir. Onlymix deps.getchangedmix.lock(it added sobelow 0.16.0).What Sobelow reported
There were no findings, at any threshold (I also ran it with no
--threshold). espex is not a Phoenix app, so Sobelow prints a "cannot find the router" warning and skips the router-based checks. It also prints harmless warnings while parsingmix.lock. No--ignoreflags or# sobelow_skipcomments were needed.Validation (run locally on this branch)
mix deps.get --check-locked: okmix compile --warnings-as-errors --force(MIX_ENV=test): okmix format --check-formatted: okmix sobelow --skip --exit --threshold medium: exit 0, no findingsmix credo --strict: no issuesmix dialyzer: passedmix hex.audit: no retired or security-advisory packagesmix deps.unlock --check-unused: okmix argus --fail-above 0: 0 findingsmix test: 4 doctests, 420 tests, 0 failures🤖 Generated with Claude Code
https://claude.ai/code/session_01UmkxCtMk3Y8vf2b42ZyVTu
Generated by Claude Code