Add other-tab command variants - #214
Merged
Merged
Conversation
Helm 4.x gained tab-bar actions (`helm-ff-find-file-other-tab'); mirror the existing other-window/other-frame plumbing so finding files, finding directories and switching projects can each open in a new tab: - `helm-projectile-find-file-other-tab' (with the sync/streaming and Dired source variants, so it honors `helm-projectile-find-file-strategy' like the other find-file commands), - `helm-projectile-find-dir-other-tab' (via a new `helm-projectile-dired-find-dir-other-tab' action using `dired-other-tab'), - `helm-projectile-switch-project-other-tab' (which switches with `helm-projectile-find-file-other-tab' as the project action). "Open in other tab" is also added to the project and directory action lists and bound to `C-c t' inside those Helm sessions. Projectile has no `projectile-*-other-tab' commands to remap onto, so these are provided as autoloaded commands (and in-Helm actions) rather than bound onto `projectile-command-map'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills the Helm-evolution gap surfaced in the audit: Helm 4.x gained tab-bar actions (
helm-ff-find-file-other-tab), but helm-projectile only had other-window and other-frame variants. This mirrors that plumbing so finding files, finding directories and switching projects can each open in a new tab:helm-projectile-find-file-other-tab- with the sync/streaming and Dired source variants, so it honorshelm-projectile-find-file-strategylike the other find-file commandshelm-projectile-find-dir-other-tab- via a newhelm-projectile-dired-find-dir-other-tabaction (dired-other-tab)helm-projectile-switch-project-other-tab- switches withhelm-projectile-find-file-other-tabas the project action"Open in other tab" is also added to the project and directory action lists and bound to
C-c tinside those Helm sessions. Withinhelm-projectile-find-filethe tab action already works via Helm's inheritedC-c C-t.Projectile has no
projectile-*-other-tabcommands to remap onto (andC-c p tis alreadytoggle-test), so these are autoloaded commands + in-Helm actions rather than forced ontoprojectile-command-map. README documents them; 4 new specs (63 total).M-x checkdocwarnings