Add helm-projectile-mode global minor mode - #216
Merged
Conversation
Replace the ad-hoc `helm-projectile-on'/`-off'/`-toggle' trio with a proper global minor mode. `helm-projectile-mode' installs and removes the Projectile command remaps (the old toggle logic, now factored into `helm-projectile--setup'); the three legacy commands become thin, obsolete wrappers around it. Loading the package no longer has unconditional global side effects: the advice on `helm-find-file-or-marked' and `helm-grep-ag-1' and the `C-c p f' binding in `helm-etags-map' now install with the mode and are removed when it is turned off, so they only affect plain Helm while Helm-Projectile is actually enabled.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the five prioritized improvements. Replaces the ad-hoc
helm-projectile-on/-off/-toggletrio with a proper global minor mode.helm-projectile-mode(:global t) installs/removes the Projectile command remaps (the old toggle logic, factored intohelm-projectile--setup).helm-projectile-on,-offand-toggleare kept as thin obsolete wrappers, so existing configs keep working.helm-find-file-or-markedandhelm-grep-ag-1, and theC-c p fbinding inhelm-etags-map, now install with the mode and are removed when it's turned off. Previously they were active from load whether or not you ever enabled Helm-Projectile - so plain Helm usage was affected. Now they're scoped to the mode.README updated to recommend
(helm-projectile-mode). Tests updated to drive the mode and assert the advice installs/removes with it (66 specs).M-x checkdocwarnings