Raise test coverage to ~55% - #219
Merged
Merged
Conversation
Cover the command/dispatch layer that regressions would hit hardest: - `helm-projectile' entry point (in-project sources vs. switch-project fallback); - `helm-projectile-grep' argument hand-off; - `helm-projectile-file-persistent-action' file preview; - the single-candidate paths of `helm-projectile--find-file-dwim-1' and `helm-projectile--find-other-file-1'; - `helm-projectile-dired-files-delete-action', the remaining virtual-Dired action, against a sandbox project. Also resolve the sandbox root to its truename so it matches the paths Dired reports back (on macOS the temp dir is under a symlinked /var). Coverage goes from ~46% to ~55% (75 specs, up from 68).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 46.60% 55.17% +8.57%
==========================================
Files 1 1
Lines 560 560
==========================================
+ Hits 261 309 +48
+ Misses 299 251 -48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 on the list. Covers the command/dispatch layer - the part a regression from all the recent churn would hit hardest:
helm-projectileentry point (in-project sources vs. switch-project fallback)helm-projectile-grepargument hand-off to the deferred runnerhelm-projectile-file-persistent-actionfile previewhelm-projectile--find-file-dwim-1andhelm-projectile--find-other-file-1helm-projectile-dired-files-delete-action, the remaining virtual-Dired action, against a sandbox projectAlso makes the sandbox fixture resolve its root to a truename so it matches the paths Dired reports back (on macOS the temp dir lives under a symlinked
/var->/private/var).Coverage: ~46% -> ~55% (75 specs, up from 68). Remaining gaps are mostly
dired-files-add-actionand the rg/ag switch-project actions - a possible future pass.M-x checkdocwarnings