Add :package-version to every defcustom - #220
Merged
Merged
Conversation
None of the 13 options carried a `:package-version', so Customize and `M-x customize-changed' couldn't tell users which release introduced (or last changed) each one. Add it to all of them, with versions derived from each option's introducing release.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 560 560
=======================================
Hits 309 309
Misses 251 251 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the five improvements (the Codecov half of #5 already landed once you added the token). None of the 13
defcustoms carried a:package-version, so Customize couldn't say which release introduced each option andM-x customize-changedcouldn't surface them on upgrade.Adds
:package-version '(helm-projectile . "X")to all 13, with the version for each derived from git archaeology (the first release tag whose history contains the option's introduction). Recent ones map to 1.6.0; the oldest to 0.14.0 / 1.0.0.M-x checkdocwarnings