WS 3175 - Show Tipo headline on Live pages at the top of sports data header - #14357
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The sport-data header can produce an empty/meaningless <h1> when the sport title is missing, which is an accessibility regression that should be fixed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Live pages with sports data so the sportDataEventContent.title (“Tipo headline”) is displayed at the top of the sport data header area.
Changes:
- Plumbs
sportDataEventContent.titlefromLivePageLayoutinto theHeadercomponent for sport-data live pages. - Updates the sport-data header markup/styling to render the sport title alongside the live label.
- Adjusts Live page tests to reflect the new sport-title behaviour, and adds a fixture for local verification.
File summaries
| File | Description |
|---|---|
| ws-nextjs-app/pages/[service]/live/[id]/LivePageLayout.tsx | Extracts sportDataEventContent.title and passes it down to Header as sportDataTitle. |
| ws-nextjs-app/pages/[service]/live/[id]/Header/index.tsx | Renders the passed sportDataTitle within the sport-data header layout. |
| ws-nextjs-app/pages/[service]/live/[id]/Header/styles.tsx | Adds new Emotion styles for the sport-title row and text. |
| ws-nextjs-app/pages/[service]/live/[id]/Header/LiveLabelHeader/index.styles.ts | Tweaks live label container styling for sport-data header layout. |
| ws-nextjs-app/pages/[service]/live/[id]/live.test.tsx | Updates tests around sport-data header title rendering expectations. |
| data/turkce/live/c70yqnn9ekxt.json | Adds a live page fixture containing sportDataEventContent.title for local testing. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new header styling introduces a hard-coded colour (and expands Emotion styling) that should be aligned with theming/styling conventions before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 2
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…at-the-top-of-sports-data-header
|
changes have been UX approved using preview |
…at-the-top-of-sports-data-header
Isabella-Mitchell
left a comment
Isabella-Mitchell
left a comment
There was a problem hiding this comment.
Think the code looks good thanks. I'm conscious that the title is "canon" and not trafalgar" as specified on the ticket due to the current update to the H2 size. I'd double check everything still looks ok with UX before merging. I did some brief A11y checks and it looks good.
thanks Izzy, we're currently discussing the correct sizes with UX so we'll make sure everythings okay before merging : ) |
…at-the-top-of-sports-data-header
…at-the-top-of-sports-data-header
…at-the-top-of-sports-data-header
…at-the-top-of-sports-data-header
…at-the-top-of-sports-data-header
Resolves JIRA: WS-3175
Summary
Show Tipo headline, present in sports data on Live pages at the top of sports data header
Live:
Changes on preview:
Changes on localhost(with live label):
Code changes
File summaries
sportDataEventContent.titleand passes it down toHeaderassportDataTitle.sportDataTitlewithin the sport-data header layout.sportDataEventContent.titlefor local testing.Testing
to check the title vist any live page with sports data e.g.
http://localhost:7081/turkce/live/c70yqnn9ekxtUseful Links