Update GitHub Actions to resolve Node 20 runner deprecation - #14367
Draft
Louis-Matsika wants to merge 1 commit into
Draft
Update GitHub Actions to resolve Node 20 runner deprecation#14367Louis-Matsika wants to merge 1 commit into
Louis-Matsika wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR title/intent says “Node 24” but the workflows/.nvmrc shown in the repo still target Node 22, so the PR is currently misaligned with its stated goal.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the GitHub Actions workflows used across Simorgh CI by bumping several third-party actions (e.g., actions/checkout, actions/setup-node, actions/cache, actions/github-script, actions/upload-artifact, Cypress, Slack) to newer major versions.
Changes:
- Bump core GitHub Actions to newer major versions (checkout/setup-node/cache/github-script/upload-artifact).
- Bump Cypress GitHub Action major version used by E2E workflows.
- Bump Slack GitHub Action version used for comment-threshold notifications.
File summaries
| File | Description |
|---|---|
| .github/workflows/simorgh-unit-tests.yml | Updates checkout/setup-node/cache action versions for unit test CI. |
| .github/workflows/simorgh-release-asset.yml | Updates checkout/setup-node action versions for release workflow. |
| .github/workflows/simorgh-misc-checks.yml | Updates checkout/setup-node/cache/github-script action versions for misc CI checks. |
| .github/workflows/simorgh-local-server-tests.yml | Updates checkout/setup-node/cache action versions for local server tests workflow. |
| .github/workflows/simorgh-integration-tests.yml | Updates checkout/setup-node/cache action versions for integration tests workflow. |
| .github/workflows/simorgh-e2e-special-features.yml | Updates checkout/setup-node and Cypress action versions for special-features E2Es. |
| .github/workflows/simorgh-e2e-playwright-page-types.yml | Updates checkout/setup-node and upload-artifact action versions for Playwright E2Es. |
| .github/workflows/simorgh-e2e-page-types.yml | Updates checkout/setup-node, Cypress, and upload-artifact action versions for page-type E2Es. |
| .github/workflows/simorgh-e2e-application.yml | Updates checkout/setup-node and Cypress action versions for application E2Es. |
| .github/workflows/main.yml | Updates github-script and Slack action versions for PR-comment notification workflow. |
| .github/workflows/codeql-analysis.yml | Updates checkout action version for CodeQL workflow. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+20
to
24
| - uses: actions/checkout@v5 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} |
Louis-Matsika
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Useful Links