Skip to content

Handle name of scoped package gently#45

Open
wzur wants to merge 4 commits into
bbc:mainfrom
wzur:master
Open

Handle name of scoped package gently#45
wzur wants to merge 4 commits into
bbc:mainfrom
wzur:master

Conversation

@wzur

@wzur wzur commented Feb 6, 2018

Copy link
Copy Markdown
  • stolen from npm pack

@Mousius

Mousius commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

Hi @wzur,

Would it not be simpler to specify using the --name option?
https://github.com/bbc/speculate#custom-name

@wzur

wzur commented Feb 9, 2018

Copy link
Copy Markdown
Author

Hi @DaMouse404,

It is correct, --name would do, but personally I prefer to keep RPM package name after the NMP package name based on the package.json content.

Besides it was a bit of fun to finally write some code for Node.js :)

@Mousius

Mousius commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

@wzur I'm just preparing a 2.0.0 release, as it's a breaking change I'd be interested in replacing the current --name with this approach as it makes more sense. So if you have any time to look at this and update it I'd be happy to get it merged 😸

@wzur

wzur commented Mar 22, 2018

Copy link
Copy Markdown
Author

Hi @DaMouse404 - did you just asked me to prepare the same patch for the current master branch? :)

@Mousius

Mousius commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

That'd be great @wzur!

I can remove the --name stuff separately 😸

@wzur

wzur commented Mar 23, 2018

Copy link
Copy Markdown
Author

Will do

@wzur

wzur commented Apr 9, 2018

Copy link
Copy Markdown
Author

Hi @DaMouse404 - I'm sorry for that delay, but I've been busy.

I hope this could be of some use for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants