Skip to content

fix(changelog): move the Config CRD bullet back under Unreleased - #134

Merged
bborbe merged 1 commit into
masterfrom
fix/changelog-unreleased-fold
Oct 22, 2026
Merged

bborbe merged 1 commit into
masterfrom
fix/changelog-unreleased-fold

Conversation

@bborbe

@bborbe bborbe commented Oct 22, 2026

Copy link
Copy Markdown
Owner

The #130 merge auto-resolved the CHANGELOG and placed the spec.rerunOnLostClaim CRD bullet under the already-released ## v0.116.0 section, leaving no ## Unreleased heading at all.

Evidence that this is a fold, not a correct placement:

git show v0.116.0:CHANGELOG.md | grep -c 'rerunOnLostClaim as .{type: boolean}.'   # 0
git tag --contains 1d880fff                                                        # (empty)
awk '/^## /{sec=$0} /configSpecProperties/{print sec}' <(git show origin/master:CHANGELOG.md)
#   -> ## v0.116.0   (a tag that does not contain the work)

The work is in no tag, so the entry moves back to ## Unreleased. v0.116.0's own file never carried it, so removing it there is not history editing.

The bullet also drops its chart 0.14.1→0.15.0 claim. That bump was clusterAssigner.excludeAssignees, released as v0.117.0; this change carries no bump of its own and ships inside the already-published chart 0.15.0.

Note on the guard

git diff origin/master -- CHANGELOG.md | grep -E '^--[^-]' reports one hit — the old wording of the moved bullet. That is this PR's own entry being reworded, not another author's entry being dropped; the net diff is +4/−1 on a single bullet.

The #130 merge placed the spec.rerunOnLostClaim CRD bullet under the already-released v0.116.0 section and left no Unreleased heading, so the entry sat in a tag that does not contain it (git tag --contains 1d880ff is empty) and the next release would not have cut it.

Also drops the 0.14.1->0.15.0 claim: that bump was clusterAssigner.excludeAssignees, released as v0.117.0. This change ships inside the published chart 0.15.0 with no bump of its own.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
  "verdict": "approve",
  "summary": "Docs-only changelog fix: the Config CRD bullet is correctly moved out of the released `## v0.116.0` section into a new `## Unreleased` heading directly above `## v0.117.0`, with no duplicate and no other author's entries touched (1 file, +4/−1). The chart-version claims check out against history (chart reached 0.15.0 at the excludeAssignees merge / v0.117.0 and the CRD merge at 1d880ff left it at 0.15.0), and no changelog lint exists in `make test`/`make precommit` or CI. Selector mode: 3 changelog candidates, 3 applicable, 0 violations; mechanical funnel returned 0 findings.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness: Verify the moved bullet now sits under a real `## Unreleased` heading that precedes `## v0.117.0`, and that the deletion fully removes the copy from the released `## v0.116.0` section (no duplicate entry in either place).",
      "disposition": "addressed",
      "detail": "CHANGELOG.md:11 is the sole `## Unreleased` heading, immediately above `## v0.117.0` at line 15; the bullet is present at line 13. The v0.116.0 copy is deleted, and the section's other bullet (the rerunOnLostClaim render entry, line 21) is intact. `grep rerunOnLostClaim` returns only the Unreleased bullet and that pre-existing v0.116.0 render bullet — no duplicate of the moved entry."
    },
    {
      "concern": "correctness: The new bullet asserts release facts: shipped in chart 0.15.0 with no bump of its own, and that `clusterAssigner.excludeAssignees` took the chart to 0.15.0. Confirm these match the tags/history rather than the PR description alone.",
      "disposition": "not-an-issue",
      "detail": "History confirms the version relationships: `helm/Chart.yaml` is 0.15.0 at the excludeAssignees merge 923e984 (released as v0.117.0) and remains 0.15.0 at the CRD merge 1d880ff, so the CRD change bumped nothing of its own and excludeAssignees is what took the chart to 0.15.0 (v0.117.0 entry: chart 0.14.1→0.15.0). The one claim not derivable from repo state is that the artifact was *published* at 0.15.0 after this change — chart publishing is a manual OCI step outside CI, and the author (maintainer) asserts it; nothing in the repo contradicts it and the current chart 0.15.0 does contain the CRD change."
    },
    {
      "concern": "correctness: PR body notes a diff guard reports one hit on the removed line. Confirm the net change is only this PR's own reworded bullet (+4/−1) and that no other author's changelog entry was dropped or reordered.",
      "disposition": "addressed",
      "detail": "`git diff --stat origin/master...HEAD` is exactly `CHANGELOG.md | 5 ++++-`, 4 insertions / 1 deletion. The additions are the blank line, `## Unreleased`, blank line and the reworded bullet; the single deletion is the old CRD bullet under v0.116.0. No other section or entry was added, removed, or reordered."
    },
    {
      "concern": "tests: Docs-only change with no test impact; check whether the repo has a changelog lint/format check (e.g. in `make test` or CI) that the new heading and bullet ordering must satisfy.",
      "disposition": "not-an-issue",
      "detail": "No changelog lint exists: `make test` is `test-helm` + `go test`, `make precommit` is ensure/format/generate/test/check/addlicense, and `.github/workflows/ci.yml` only runs `make precommit`; none inspects CHANGELOG.md. The only gates are `docs/dod.md` (\"entry under `## Unreleased`\", satisfied) and the maintainer autoRelease bot renaming `## Unreleased`→`## vX.Y.Z` (satisfied, single heading). The `feat(helm):` prefix matches the repo's uniform scope convention across all released entries."
    }
  ]
}

@bborbe
bborbe merged commit dc043b2 into master Oct 22, 2026
3 checks passed
@bborbe
bborbe deleted the fix/changelog-unreleased-fold branch October 22, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant