Repository navigation
update go module dependencies - #136
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "Dependency-only PR (CHANGELOG.md, go.mod, go.sum) updating 6 direct bborbe modules plus 4 indirect ones. The mechanical funnel reported 0 findings, and the judgment-tier candidates for CHANGELOG.md/go.mod/go.sum (conventional prefix, frozen preamble, Unreleased entry, go mod tidy side effects, no cross-repo replace) all pass. The one anomaly — go-openapi/swag dropping from v0.29.1 to v0.27.1 in go.sum — is an expected MVS consequence, not a manual edit: vault-cli v0.177.0 required the root swag module at v0.29.1, and v0.178.3 no longer does, so the remaining graph requirement (v0.27.1) wins. GitHub Actions CI run 19317348984 (`make precommit`: go mod tidy, go mod verify, gofmt/generate, go test -race, golangci-lint, go vet, govulncheck, osv-scanner, trivy) completed successfully on this exact head SHA 1154d9a.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness: transitive module github.com/go-openapi/swag is DOWNGRADED from v0.29.1 to v0.27.1, contradicting the PR claim that modules were bumped to their latest versions",
"disposition": "not-an-issue",
"detail": "Verified via the module proxies: vault-cli v0.177.0's go.mod required github.com/go-openapi/swag v0.29.1 (root) plus its submodules at v0.29.1; vault-cli v0.178.3 requires only swag/conv, jsonutils, pools, typeutils at v0.29.2 and no root swag. With the v0.29.1 pin gone, MVS correctly selects the next-highest remaining requirement, v0.27.1. The submodules stay at v0.29.2 because vault-cli v0.178.3 and kube-openapi v0.0.0-20261014044854 require them at v0.29.2 / v0.27.1 respectively and MVS takes the max. go.sum:71 remains an h1-only entry, exactly as it was on master for v0.29.1 — pre-existing shape, not introduced here. The root swag module is not listed in go.mod and is not imported by any package in the build, so the version change cannot affect compilation."
},
{
"concern": "security: downgrading go-openapi/swag may reintroduce vulnerabilities fixed between v0.27.1 and v0.29.1; confirm the vulncheck gate covers the transitive graph",
"disposition": "not-an-issue",
"detail": "CI on head SHA 1154d9a ran `make precommit` → `check: lint vet vulncheck osv-scanner trivy` and completed with conclusion success. govulncheck analyzes the full package build graph, and osv-scanner + trivy scan the module manifests/lockfile; none is limited to direct modules. No swag entry is present in .trivyignore or .osv-scanner.toml (only docker/docker, bbolt, and x/crypto/openpgp advisories are ignored)."
},
{
"concern": "correctness: github.com/bborbe/vault-cli jumps v0.177.0 to v0.178.3; in a 0.x module semver permits breaking changes across minor versions",
"disposition": "not-an-issue",
"detail": "The repo imports only github.com/bborbe/vault-cli/pkg/domain (task enums) across 10 files. The 0.177.0→0.178.3 bump compiles and passes the full `go test -race ./...` suite in CI on this head SHA, which is the direct verifier for any API change affecting those call sites."
},
{
"concern": "correctness: PR body reports 10 dependencies updated but the CHANGELOG entry documents only 6; the indirect bumps k8s, math, run, and strimzi are undocumented",
"disposition": "not-an-issue",
"detail": "The CHANGELOG entry lists exactly the 6 directly required modules bumped (collection, errors, http, kafka, validation, vault-cli); k8s, math, run and strimzi are `// indirect`. This matches the established repo convention — the prior dependency-update commit d4f7838 lists only direct modules and the Go version, not indirect ones. The entry satisfies changelog/unreleased-entry-required, starts with the `chore:` prefix required by changelog/conventional-prefix-required, and is placed directly above the highest version section per changelog/preamble-frozen."
},
{
"concern": "correctness: no source files changed, so correctness rests on go.mod/go.sum consistency; verify with go mod tidy -diff, go mod verify, and a clean build",
"disposition": "not-an-issue",
"detail": "CI (`make precommit` → `ensure: go mod tidy; go mod verify`, then generate, `go test -race ./...`, lint, vet, vulncheck, osv-scanner, trivy) ran on this head SHA and passed. Note: the repo's `ensure` target runs `go mod tidy` without a `git diff --exit-code`, so a non-tidy state would not fail CI, but `go mod verify` plus a successful build of every package confirms every needed go.sum entry is present and correct. Every bumped module in go.sum has both h1 and /go.mod hashes."
},
{
"concern": "tests: PR asserts precommit, check, and vulncheck all exited 0; confirm CI actually re-ran against this head SHA rather than a pre-update run",
"disposition": "not-an-issue",
"detail": "Confirmed via the GitHub Actions API: workflow run 19317348984 (CI / test) is keyed to head_sha 1154d9a2d7c1bc982ed5b8fee45a6e0da9fb3c28, the exact reviewed commit, and completed with conclusion `success` at 2026-10-22T11:05:01Z. The other runs on this SHA are check-do-not-merge/check-unfinished-pipeline, which are expected."
},
{
"concern": "performance: dependency version bumps could alter runtime behavior in kafka, http, and k8s libraries used at request/message handling time",
"disposition": "not-an-issue",
"detail": "All bborbe library bumps are patch-level (collection 1.21.3→1.21.4, errors 1.6.3→1.6.4, http 1.26.30→1.26.31, kafka 1.28.5→1.28.6, validation 1.5.5→1.5.6, k8s 1.14.23→1.14.24, math 1.4.15→1.4.16, run 1.11.2→1.11.3, strimzi 1.8.21→1.8.22); only vault-cli crosses a 0.x minor, and the repo uses only its domain enum types, not its runtime code. No behavioral change is introduced in this repo's own code, and the full race-enabled test suite passes on the bumped graph."
}
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Go toolchain + dependency update.
CHANGELOG entry stays under
## Unreleased— the release agent versions and tags on merge.