Repository navigation
nginx: remove driftline vhost - #53
Merged
Merged
Conversation
bborbe
marked this pull request as ready for review
October 18, 2026 18:45
There was a problem hiding this comment.
The mechanism is confirmed correct. In bundles/nginx/items.py:73-77, delete_vhosts is an established pattern that creates a delete: True entry for /etc/nginx/sites-enabled/{filename} with an nginx restart trigger. The diff adds delete_vhosts: ['driftline.conf'] which will delete /etc/nginx/sites-enabled/driftline.conf and restart nginx — consistent with how the driftline vhost was previously managed.
The diff is clean: the driftline vhost dict is removed and the delete_vhosts entry is added to clean up the orphaned file. The comment documents the exact scoped apply command needed to trigger it.
{
"verdict": "approve",
"summary": "The diff cleanly removes the driftline vhost dict and adds delete_vhosts to remove the orphaned nginx config file. The mechanism (bundles/nginx/items.py delete_vhosts pattern) and file path (/etc/nginx/sites-enabled/driftline.conf) are correct and consistent with the existing codebase.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness: delete_vhosts uses scoped apply to remove driftline.conf; ensure this is the intended mechanism and the file path is correct",
"disposition": "addressed",
"detail": "bundles/nginx/items.py:73-77 shows delete_vhosts is an established pattern that creates delete entries for /etc/nginx/sites-enabled/{filename} with nginx restart. The path /etc/nginx/sites-enabled/driftline.conf is consistent with the removed vhost. The diff comment documents the exact scoped apply command needed to trigger it."
}
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
driftlinevhost added in #52 — the driftline leaderboard phase is on hold and the server is being torn down.nginx.vhostsnginx.delete_vhosts: ['driftline.conf']so the file is actually deleted (dropping the vhost only unmanages it); the item triggers the nginx restart/etc/netplandrift):bw apply hz.hetzner-1 -o file:/etc/nginx/sites-enabled/driftline.confdelete_vhostsentry can be dropped in a follow-up once the file is gone.Checks on the branch:
bw test hz.hetzner-1✓bw verify hz.hetzner-1 -o file:/etc/nginx/sites-enabled/driftline.conf→ 1 bad (file present, to be deleted), 284 skippedThe LE cert
driftline.benjamin-borbe.deis removed withcertbot deleteafter the apply (not bw-managed).