Skip to content

nginx: remove driftline vhost - #53

Merged
bborbe merged 2 commits into
masterfrom
chore/remove-driftline-vhost
Oct 18, 2026
Merged

bborbe merged 2 commits into
masterfrom
chore/remove-driftline-vhost

Conversation

@bborbe

@bborbe bborbe commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Removes the driftline vhost added in #52 — the driftline leaderboard phase is on hold and the server is being torn down.

  • vhost block dropped from nginx.vhosts
  • nginx.delete_vhosts: ['driftline.conf'] so the file is actually deleted (dropping the vhost only unmanages it); the item triggers the nginx restart
  • Apply is scoped, never a full apply (pre-existing /etc/netplan drift):
    bw apply hz.hetzner-1 -o file:/etc/nginx/sites-enabled/driftline.conf
  • The delete_vhosts entry can be dropped in a follow-up once the file is gone.

Checks on the branch:

  • bw test hz.hetzner-1 ✓
  • bw verify hz.hetzner-1 -o file:/etc/nginx/sites-enabled/driftline.conf → 1 bad (file present, to be deleted), 284 skipped

The LE cert driftline.benjamin-borbe.de is removed with certbot delete after the apply (not bw-managed).

@bborbe
bborbe marked this pull request as ready for review October 18, 2026 18:45

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanism is confirmed correct. In bundles/nginx/items.py:73-77, delete_vhosts is an established pattern that creates a delete: True entry for /etc/nginx/sites-enabled/{filename} with an nginx restart trigger. The diff adds delete_vhosts: ['driftline.conf'] which will delete /etc/nginx/sites-enabled/driftline.conf and restart nginx — consistent with how the driftline vhost was previously managed.

The diff is clean: the driftline vhost dict is removed and the delete_vhosts entry is added to clean up the orphaned file. The comment documents the exact scoped apply command needed to trigger it.


{
  "verdict": "approve",
  "summary": "The diff cleanly removes the driftline vhost dict and adds delete_vhosts to remove the orphaned nginx config file. The mechanism (bundles/nginx/items.py delete_vhosts pattern) and file path (/etc/nginx/sites-enabled/driftline.conf) are correct and consistent with the existing codebase.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness: delete_vhosts uses scoped apply to remove driftline.conf; ensure this is the intended mechanism and the file path is correct",
      "disposition": "addressed",
      "detail": "bundles/nginx/items.py:73-77 shows delete_vhosts is an established pattern that creates delete entries for /etc/nginx/sites-enabled/{filename} with nginx restart. The path /etc/nginx/sites-enabled/driftline.conf is consistent with the removed vhost. The diff comment documents the exact scoped apply command needed to trigger it."
    }
  ]
}

@bborbe
bborbe merged commit 6d32962 into master Oct 18, 2026
4 checks passed
@bborbe
bborbe deleted the chore/remove-driftline-vhost branch October 18, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant