sha3, rng cleanup - #94
Open
ounsworth wants to merge 1 commit into
Open
Conversation
Mechanical cleanups, no behaviour change. * std::marker::PhantomData -> core:: in sha3.rs, and std::fmt -> core:: in hash_drbg80090a.rs. Neither needs std; both crates are working towards no_std. * KeyType and SecurityStrength are Copy, so min()/max() results are dereferenced rather than .clone()d. This also lets the surrounding expressions be formatted as single calls. * Hash::hash_out() and XOF::hash_xof_out() called output.fill(0) before delegating to a path that zeroizes the buffer itself (do_final_out() and squeeze_out() respectively, per the trait contract). Dropped the outer fill; hash_out() no longer needs `mut output` or a reborrow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break up of #87, so this is actually dgh's submission. So I will be reviewing / approving.
Mechanical cleanups, no behaviour change.
use core:: imports, copy Copy types, drop a redundant zeroize
mut outputor a reborrow.