Skip to content

SUBMIT-994 simplify new-version logic and fix staff review button - #1022

Open
dinesh-aot wants to merge 1 commit into
bcgov:developfrom
dinesh-aot:SUBMIT-994
Open

SUBMIT-994 simplify new-version logic and fix staff review button#1022
dinesh-aot wants to merge 1 commit into
bcgov:developfrom
dinesh-aot:SUBMIT-994

Conversation

@dinesh-aot

Copy link
Copy Markdown
Collaborator

https://eao-dst.atlassian.net/browse/SUBMIT-994

  • Refactor useIsNewVersion to rely on backend is_updated flag
    instead of cross-checking update requests client-side
  • Remove unused itemTypeId/updateRequests props from StatusCell
    and DocumentRow
  • Exclude REVIEW_REJECTED from end statuses that hide the staff
    review confirmation button
  • Fix project listing to show all projects regardless of visible
    packages
  • Add unit tests for ManagementPlanService.require_revision

# Keep only projects with at least one visible package
visible = [p for p in projects_list if p.get("packages")]
visible_projects.extend(visible)
visible_projects.extend(projects_list)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to show all projects in the staff project list page irrespective of whether it has package or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant