Repository navigation
feat!: take cert-expiry hosts and .pr-close.yml packages one per line - #136
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Package validation rejects quoted names accepted by the shared parser, preventing retagging for those inputs.
1 open issue
What changed in this PR
Standardizes certificate host and package inputs on one item per line, replacing comma- and space-separated lists.
Changes:
- Uses the shared parser for certificate hosts and inline validation for packages.
- Updates input documentation and certificate tests.
- Runs certificate tests when the shared parser changes.
| File | Description |
|---|---|
cert-expiry/README.md |
Documents the new host format. |
cert-expiry/check.sh |
Parses hosts through the shared helper. |
cert-expiry/action.yml |
Updates the host input description. |
.github/workflows/cert-expiry-tests.yml |
Adds shared-parser changes to test triggers. |
.github/workflows/.pr-close.yml |
Parses and validates newline-separated packages. |
.github/tests/cert-expiry/check.bats |
Updates fixtures and tests rejected separators. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cert-expiryhostsand the.pr-close.ymlpackagesinput still split on commas and spaces, unlike every other list input, which takes one item per line.cert-expiryhosts: one host per line, or a single host, throughshared/inputs.sh. Blank lines and# commentsare still skipped. Commas and spaces fail with the shared format error. README, description and bats tests updated; the cert-expiry tests now also run onshared/inputs.shchanges..pr-close.ymlpackages: one package per line, or a single package, with the same rules and error. A reusable workflow cannot read this repository's files, so the check is inline.shared/inputs.sh: list format errors keep quotes on items that contain spaces (same as feat(shared)!: take list inputs one item per line or as a single value actions#311); bats test covers it..pr-close.yml:remove_pvcandcleanup_nametake one per line or a single value; cleanup-pr and sysdig-monitor docs updated..pr-close.ymlpackages: strips one matching pair of outer quotes per item, asshared/inputs.shdoes.