Skip to content

feat!: take cert-expiry hosts and .pr-close.yml packages one per line - #136

Merged
DerekRoberts merged 3 commits into
mainfrom
feat/hosts-packages-one-per-line
Oct 21, 2026
Merged

DerekRoberts merged 3 commits into
mainfrom
feat/hosts-packages-one-per-line

Conversation

@DerekRoberts

@DerekRoberts DerekRoberts commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

cert-expiry hosts and the .pr-close.yml packages input still split on commas and spaces, unlike every other list input, which takes one item per line.

  • cert-expiry hosts: one host per line, or a single host, through shared/inputs.sh. Blank lines and # comments are still skipped. Commas and spaces fail with the shared format error. README, description and bats tests updated; the cert-expiry tests now also run on shared/inputs.sh changes.

  • .pr-close.yml packages: one package per line, or a single package, with the same rules and error. A reusable workflow cannot read this repository's files, so the check is inline.

  • shared/inputs.sh: list format errors keep quotes on items that contain spaces (same as feat(shared)!: take list inputs one item per line or as a single value actions#311); bats test covers it.

  • .pr-close.yml: remove_pvc and cleanup_name take one per line or a single value; cleanup-pr and sysdig-monitor docs updated.

  • .pr-close.yml packages: strips one matching pair of outer quotes per item, as shared/inputs.sh does.

@DerekRoberts DerekRoberts self-assigned this Oct 20, 2026
@DerekRoberts DerekRoberts moved this to New in DevOps (NR) Oct 20, 2026
@DerekRoberts
DerekRoberts marked this pull request as ready for review October 20, 2026 21:16
Copilot AI balanced review requested due to automatic review settings October 20, 2026 21:16
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Package validation rejects quoted names accepted by the shared parser, preventing retagging for those inputs.

1 open issue
What changed in this PR

Standardizes certificate host and package inputs on one item per line, replacing comma- and space-separated lists.

Changes:

  • Uses the shared parser for certificate hosts and inline validation for packages.
  • Updates input documentation and certificate tests.
  • Runs certificate tests when the shared parser changes.
File Description
cert-expiry/​README.md Documents the new host format.
cert-expiry/​check.sh Parses hosts through the shared helper.
cert-expiry/​action.yml Updates the host input description.
.github/​workflows/​cert-expiry-tests.yml Adds shared-parser changes to test triggers.
.github/​workflows/​.pr-close.yml Parses and validates newline-separated packages.
.github/​tests/​cert-expiry/​check.bats Updates fixtures and tests rejected separators.

Review effort: Balanced

Comment thread .github/workflows/.pr-close.yml Outdated
@DerekRoberts
DerekRoberts merged commit 46f2614 into main Oct 21, 2026
31 checks passed
@DerekRoberts
DerekRoberts deleted the feat/hosts-packages-one-per-line branch October 21, 2026 03:19
@github-project-automation github-project-automation Bot moved this from Active to Done in DevOps (NR) Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants