fix(rapier): reject snapshot restore after body membership changes - #299
Open
Ram-Dawson wants to merge 2 commits into
Open
fix(rapier): reject snapshot restore after body membership changes#299Ram-Dawson wants to merge 2 commits into
Ram-Dawson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298
Problem
Native Rapier snapshots can restore the native world, but do not recreate Dart pose targets or application-owned body registrations.
restore()could accept a snapshot after a body was created or destroyed, leaving the native world and Dart body registry out of sync.Change
Encode the Dart body-handle set alongside the native snapshot bytes. Decode and compare that set with the current
_bodieskeys before calling native restore. Returnfalsewhen membership differs, leaving the current native world untouched.Validation
packages/flutter_scene_rapier:fvm flutter test test/world_snapshot_test.dartScope and limitation
This PR protects the low-level
RapierWorldcontract. It does not implement application-level object-graph rollback, automatically destroy Dart-owned objects, reconstruct external pose targets, or change snapshot behavior when body membership is unchanged.