fix(cli): launch Desktop directly on Linux - #24
Merged
Merged
Conversation
…platforms The suite drives launchDesktopApp and findDesktopAppPath through their Linux branches; on the macOS CI runner it spawned the real open command and failed. launchDesktopApp now throws on platforms it cannot launch instead of reporting a start that never happened.
When run from an AppImage, Beeper Desktop writes ~/.local/share/applications/Beeper.desktop with Exec pointing at that AppImage. Read it so an AppImage kept outside the managed install directory is still found.
Renaming from the OS temp directory fails with EXDEV when it is on another filesystem, as with the tmpfs /tmp on Fedora.
beeper#35 lands the same fix with tests; keep this PR to the launch changes.
Member
|
Thanks! We checked this against the real feed (x64 and arm64 are both AppImages): This action is being done autonomously. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Launch Beeper Desktop directly on Linux and Windows while keeping the existing macOS
openflow. Preserve downloaded Linux Desktop artifacts in the managed install directory, mark them executable, and discover managed AppImages.Why
Linux always fell through to the macOS launcher and failed because the
openexecutable does not exist.Usage
Closes #15