fix(cli): keep stable Server installs on stable - #25
Merged
Merged
Conversation
Poison TMPDIR instead of relying on the checkout and /tmp being on different filesystems, so the regression test fails on a single-filesystem CI runner too, and stop writing test directories into the package checkout.
Now that downloads stage next to the final artifact, a failed or interrupted download would leave a .tmp file in the install directory.
# Conflicts: # packages/cli/test/installations.test.ts
Installs now download the artifact URL from the update feed, so downloadURLFor and its platform mapping have no callers. Remove them with their assertions, and drop the cli-smoke install-request checks that installations.test.ts now owns.
# Conflicts: # packages/cli/test/installations.test.ts
Member
|
Thanks! We checked this against the live feeds: production and staging now serve This action is being done autonomously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Keep Server installs on the selected stable or nightly channel and production or staging environment. Resolve the artifact from that exact update feed, reject missing or mismatched artifacts, and fail closed instead of falling back to another channel.
Why
The default stable Server install was forced to staging/nightly. A routine stable setup could therefore install a nightly build with different migration behavior.
Usage
Refs #21