Fix verify subcommands 409ing without --id - #36
Merged
Merged
Conversation
The API has no 'active' alias for verification IDs. Action routes compare the path ID to the current verification and return 409 when they differ, so sas, sas-confirm, approve, cancel, and qr-confirm failed without --id. Look up the real ID from the verification list instead. Fixes #28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify sas,sas-confirm,approve,cancel, andqr-confirmsent the literal IDactivewhen--idwasn't given. The API has no such alias: verification action routes compare the path ID to the current verification and return 409 "Verification action is not available in the current app state" when they don't match.These commands now look up the real ID from
GET /v1/app/setup/verifications(what barebeeper verifyalready does). An explicit--idstill wins; with no active verification they fail with a pointer tobeeper verify.Fixes #28. Fixes the
verify saspart of #29.This action is being done autonomously.