Skip to content

bug: 🐛 fix skin tone emoji reaction mapping#177

Open
clins1994 wants to merge 1 commit into
beeper:mainfrom
clins1994:caio/skin-tone-emojis
Open

bug: 🐛 fix skin tone emoji reaction mapping#177
clins1994 wants to merge 1 commit into
beeper:mainfrom
clins1994:caio/skin-tone-emojis

Conversation

@clins1994

@clins1994 clins1994 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Please merge #179 then update this with latest changes before reviewing

Summary

  • Strip Unicode skin tone modifiers when normalizing Matrix reaction keys
  • Reuse the existing base emoji LINE reaction mappings for skin tone variants

Fixes #176

Testing

  • go test ./pkg/connector

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The normalizeMatrixReactionKey function in the reaction handler now filters out Unicode skin-tone modifier runes during normalization. Emoji reactions that differ only by skin-tone variants (U+1F3FB–U+1F3FF) are now treated as equivalent for LINE emoji mapping lookup.

Changes

Emoji Skin-Tone Modifier Normalization

Layer / File(s) Summary
Skin-tone modifier stripping in reaction normalization
pkg/connector/reaction.go
The rune-filtering step in normalizeMatrixReactionKey now removes skin-tone modifier code points by mapping them to -1, before applying the existing variation-selector filtering and key-reduction logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The code changes directly address issue #176 by stripping Unicode skin tone modifiers during normalization so variants map to base emoji LINE reactions.
Out of Scope Changes check ✅ Passed All changes are scoped to normalizing skin tone modifiers in reaction key mapping, with no unrelated modifications outside the stated objective.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing skin tone emoji reaction mapping by stripping Unicode modifiers. It is concise, relevant to the changeset, and accurately reflects the primary objective addressed in the PR.
Description check ✅ Passed The pull request description clearly relates to the changeset, outlining the specific feature being implemented and referencing the issue it addresses.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@clins1994 clins1994 changed the title Fix skin tone emoji reaction mapping feat: ✨ fix skin tone emoji reaction mapping Jun 11, 2026
@clins1994 clins1994 changed the title feat: ✨ fix skin tone emoji reaction mapping bug: 🐛 fix skin tone emoji reaction mapping Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

bug: 🐛 Matrix reactions with skin tone modifiers do not map to LINE emojis

1 participant