Repository navigation
Conversation
Imkkey
commented
Oct 13, 2026
Imkkey
left a comment
Author
There was a problem hiding this comment.
Source review found one reload failure-preservation gap. This case has not been runtime-tested.
Imkkey
marked this pull request as ready for review
October 14, 2026 06:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration.reload()rereads YAML sources withdict.update(), so keys removed from a file remain in memory. Deleted overrides continue to mask lower-priority defaults, and empty files or deleted optional files retain all previous settings. Reordering a file also leaves the old key order in place.Clear the source after successfully loading and validating the replacement mapping, then populate it with the new contents. Keep the same source object and metadata. Parse errors, invalid non-mapping documents, and missing required files still leave the previous contents intact.
Add regression coverage for deleted overrides falling back to defaults, removal of keys without defaults, empty documents, optional-file deletion and recreation, key order, source identity and metadata, and preserving existing data on failed reloads. In-memory configuration sources remain unchanged.
Validation on Python 3.12.14:
null/~controls; all 16 added cases pass on c523030.test_bump_version_applies_sequential_changelog_updates. Clean upstream has the same failure (300 passed, one failed): its expected changelog underline is fixed at 26 characters, while the October heading requires 24. The untouched previous PR head also reproduces it (309 passed, one failed).git diff --checkpass.action_required, awaiting maintainer approval, with zero jobs executed. Remote CI has not passed.Prepared and checked with OpenAI Codex assistance.