Complete the attribute catalogue and the light characters - #72
Merged
Conversation
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 5, 2026 02:23
7995fe4 to
02f9d12
Compare
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
2 times, most recently
from
September 6, 2026 20:27
d1b0034 to
5ad8b7f
Compare
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 6, 2026 23:08
5ad8b7f to
f1782e1
Compare
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 6, 2026 23:27
f1782e1 to
892c9ef
Compare
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 7, 2026 02:01
892c9ef to
9f60836
Compare
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 7, 2026 02:15
9f60836 to
873987a
Compare
CATHAF, code 30, was absent from the transcribed table, so a harbour facility reported its category as a bare number. It is the only feature attribute in Appendix A chapter 2 the table lacked. HUNITS was labelled "Height units"; 2.135 names it "Height/length units" and scopes it to heights and lengths, the case HORLEN and HORWID need. The table had no test. A new one cross-checks every acronym against the S-57 attribute list, which ships with the spec rather than this repo, so it reads the path from TILE57_S57_ATTRIBUTES and skips without it. litchr_abbrev holds a chart abbreviation for 16 of the 29 LITCHR codes, and the other 13 returned null, which dropped the character, the period and the range from the report of an alternating light. litchrText names those from the catalogue instead. Appendix A 2.146 gives each code's meaning and leaves the abbreviation to INT 1, so no new abbreviations are invented here. A feature whose attribute blob does not parse reported "empty":"none", the same as one with no attributes, so a corrupted wreck read as a wreck recording no depth. The report says "unreadable" for that case.
The catalogue cross-check reads its CSV path from the environment through libc's getenv, as the other real-file tests here do. The s57 package test is the only module holding such a test that does not link libc. macOS links it implicitly, so the test built on this machine and failed to compile for a target that does not: error: dependency on libc must be explicitly specified in the build command ... referenced by test.the transcribed table agrees with the S-57 attribute list Checked with zig build test -Dtarget=x86_64-linux-gnu, which now compiles every test binary.
beetlebugorg
force-pushed
the
fix/ingest-pick-report
branch
from
September 7, 2026 02:26
873987a to
3019bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATHAF, code 30, was absent from the transcribed attribute table, so a harbour facility reported its category as a bare number. It is the only feature attribute in Appendix A chapter 2 the table lacked, and a new test cross-checks every acronym against the S-57 attribute list. HUNITS was labelled "Height units". 2.135 names it "Height/length units". Stacked on #71.
litchr_abbrevholds a chart abbreviation for 16 of the 29 LITCHR codes, and the other 13 returned null, which dropped the character, the period and the range from the report of an alternating light.litchrTextnames those from the catalogue. A feature whose attribute blob does not parse reported"empty":"none", the same as one with no attributes, so a corrupted wreck read as a wreck recording no depth. The report saysunreadablefor that case.The new test reads its CSV path through libc's getenv, and the s57 package test was the one module holding such a test without linking libc. macOS links it implicitly, so this only failed to compile for a target that does not.
zig build,zig build testandzig fmt --checkpass, andzig build test -Dtarget=x86_64-linux-gnucompiles every test binary.