Stop collecting src/chart.zig tests - #76
Merged
Merged
Conversation
The test module addPkgTest builds for it links portray's lua_shim.c,
which references tgc_binding, an export in src/s101/catalogue.zig that
the module does not emit. macOS linked it and ld.lld on Linux did not:
error: ld.lld: undefined symbol: tgc_binding
note: referenced by lua_shim.c:620
build-test failed on main at the merge that added the registration, and
passed on its parent.
The seven tests in src/chart.zig go back to uncollected, three that were
there before and four for the inventory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-testfails on main. The test moduleaddPkgTestbuilds forsrc/chart.ziglinks portray'slua_shim.c, which referencestgc_binding, an export insrc/s101/catalogue.zigthat the module does not emit.macOS links it and ld.lld on Linux does not, so
zig build testpasses locally. The job failed onb2aef2d, the merge that added the registration, and passed on its parentda5442e.Registering
src/chart.zigwas not part of #75. I added it there because the inventory tests I wrote live in that file, and I checked it on macOS only.This removes the registration. The seven tests in
src/chart.ziggo back to uncollected: three that predate #75 and four for the inventory. Collecting them needs the test module to link what portray's C shim references. That is its own piece of work.Checks
zig build,zig build test(420 tests) andzig fmt --checkpass.