Repository navigation
Report an actionable error when Docker is unavailable in WSL2 - #3108
Merged
freakboy3742 merged 3 commits intoOct 28, 2026
Merged
Conversation
Fixes beeware#1634 Assisted-by: OpenAI Codex (GPT-6)
freakboy3742
approved these changes
Oct 28, 2026
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
I'm not sure why this was submitted in Draft mode, but with a couple of minor tweaks it looks good to me. Thanks!
freakboy3742
marked this pull request as ready for review
October 28, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docker reports that it cannot be found inside a WSL 2 distribution, Briefcase currently warns and continues verification. Stop on that specific message and explain that Docker must be available in the distribution, with Docker Desktop WSL integration guidance. Other version-command failures retain the existing warning-and-proceed behavior.
Fixes #1634.
Added a regression for the full WSL error output, including the early stop and guidance, and coverage for absent, unrelated and localized failure output.
Validation on Windows with Python 3.14: the new regression failed before the fix; the final Docker integration suite passed 94 tests with 28 platform skips. All pre-commit hooks passed using Python 3.13 for the tooling environment, and Towncrier validated the committed change note. The initial Python 3.14 pre-commit environment failed while building the existing docformatter dependency. Real WSL/Docker Desktop reproduction and the full cross-platform suite were not run.
PR Checklist:
Assisted-by: OpenAI Codex (GPT-6)