Repository navigation
Fix license normalization type annotations. - #3112
Merged
freakboy3742 merged 1 commit intoOct 27, 2026
Merged
freakboy3742 merged 1 commit into
freakboy3742 merged 1 commit into
Conversation
The license normalizers receive mutable merged TOML dictionaries, not AppConfig instances. Annotate all five config parameters as dict[str, Any] and their return types as None, without changing runtime behavior. Removes 15 ty diagnostics and leaves config.py clean with ty 0.0.89. Refs beeware#2709.
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The license normalizers receive mutable merged TOML dictionaries, not AppConfig instances.
Annotate all five config parameters as dict[str, Any] and their return types as None, without changing runtime behavior.
Removes 15 ty diagnostics and leaves config.py clean with ty 0.0.89.
Refs #2709.
PR Checklist:
Assisted-by: openai/gpt-6.1-sol