Skip to content

refactor(code): align snippets with architectural safety standards in frontend/angular/architecture.md #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beginwebdev2002 merged 1 commit into from
Apr 9, 2026
+2 −2
Merged

refactor(code): align snippets with architectural safety standards in frontend/angular/architecture.md #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/angular/architecture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ Extract logic into services/signals. Leave only formatting to pipes.
> **Context:** TypeScript Safety
### ❌ Bad Practice
```typescript
getData(): Observable<unknown> { ... }
getData(): Observable<any> { ... }
```
### ⚠️ Problem
`any` disables type checking, nullifying the benefits of TypeScript. Errors only surface at runtime.
Expand Down Expand Up @@ -212,7 +212,7 @@ Use aliases in the template (`as varName`) or convert the stream to a signal (`t
> **Context:** DI Scopes
### ❌ Bad Practice
```typescript
@Injectable({ providedIn: 'unknown' })
@Injectable({ providedIn: 'any' })
```
### ⚠️ Problem
Creates a new service instance for each lazy-loaded module. This is often unexpected behavior, leading to state desynchronization (different singleton instances).
Expand Down
Loading