Skip to content

Add hooks for beman-tidy run#30

Merged
neatudarius merged 2 commits into
bemanproject:mainfrom
teodor994:issue/252
Apr 25, 2026
Merged

Add hooks for beman-tidy run#30
neatudarius merged 2 commits into
bemanproject:mainfrom
teodor994:issue/252

Conversation

@teodor994
Copy link
Copy Markdown
Contributor

@teodor994 teodor994 commented Apr 25, 2026

Issue: bemanproject/beman-tidy#252
Added hooks in the pre-commit-config.yaml file for beman-tidy run.
Attaching the output below:

teodorandrei@Teodors-MacBook-Pro cstring_view % pre-commit run --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-clang-format.
[INFO] Initializing environment for https://github.com/BlankSpruce/gersemi-pre-commit.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/bemanproject/beman-tidy.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-clang-format.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/BlankSpruce/gersemi-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/bemanproject/beman-tidy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
clang-format.............................................................Passed
CMake linting............................................................Passed
codespell................................................................Passed
beman-tidy...............................................................Passed

Signed-off-by: Teodor Andrei Vica <teodorvica@gmail.com>
@teodor994 teodor994 marked this pull request as ready for review April 25, 2026 09:08
@teodor994 teodor994 requested a review from dascandy as a code owner April 25, 2026 09:08
Copy link
Copy Markdown

@vickgoodman vickgoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .pre-commit-config.yaml Outdated
Copy link
Copy Markdown
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with small change in config.

Signed-off-by: Teodor Andrei Vica <teodorvica@gmail.com>
Copy link
Copy Markdown

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for first Beman Contribution!

@neatudarius neatudarius merged commit bae3c65 into bemanproject:main Apr 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants