Skip to content

Updated Mobile Menu UX, Updated Logo#8

Merged
benazeem merged 1 commit into
mainfrom
feat/shadcn-form-primitives-and-Product-data-update
Jul 8, 2026
Merged

Updated Mobile Menu UX, Updated Logo#8
benazeem merged 1 commit into
mainfrom
feat/shadcn-form-primitives-and-Product-data-update

Conversation

@benazeem

@benazeem benazeem commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Updated the site header and footer branding to use a new logo image and sizing, improving consistency across the layout.
    • Improved mobile navigation behavior so the menu closes more reliably when tapping outside it or selecting a link.

Copilot AI review requested due to automatic review settings July 8, 2026 04:48
@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ms-signature Ready Ready Preview, Comment Jul 8, 2026 4:49am

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 77c78bbc-7baf-425f-a722-96dfcab92aa1

📥 Commits

Reviewing files that changed from the base of the PR and between d77176f and 9cab254.

⛔ Files ignored due to path filters (1)
  • public/MS_Signature.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • components/layout/Footer.tsx
  • components/layout/Navbar.tsx

📝 Walkthrough

Walkthrough

The footer and navbar logo images are switched from a JPG file to a PNG file. The navbar also adds refs and a pointerdown event listener to close the mobile menu when clicking outside it or when a mobile nav link is selected.

Changes

Navbar and Footer updates

Layer / File(s) Summary
Logo image source update
components/layout/Footer.tsx, components/layout/Navbar.tsx
Logo <Image> source is switched from /MS_Signature_Logo.jpg to /MS_Signature.png, with related sizing/class updates in the navbar home link.
Mobile menu outside-click and close-on-select behavior
components/layout/Navbar.tsx
Imports are trimmed, useRef is added, and mobileMenuRef/mobileToggleRef refs are wired to the mobile menu and toggle button; a pointerdown-based effect closes the mobile menu when clicking outside it, and each mobile nav link closes the menu on click.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant MobileToggleButton
  participant Navbar
  participant Document

  User->>MobileToggleButton: click
  MobileToggleButton->>Navbar: setMobileOpen(true)
  Navbar->>Document: addEventListener("pointerdown", handler)
  User->>Document: pointerdown outside menu/toggle
  Document->>Navbar: handler(event)
  Navbar->>Navbar: setMobileOpen(false)
Loading

Possibly related PRs

  • benazeem/MS-Signature#7: Both PRs modify the mobile menu JSX in components/layout/Navbar.tsx, touching the same close-menu/link area.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/shadcn-form-primitives-and-Product-data-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@benazeem
benazeem merged commit 16290c2 into main Jul 8, 2026
3 of 4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the site’s branding assets and improves the mobile navigation experience by making the menu easier to dismiss and ensuring it closes after navigation.

Changes:

  • Updated Navbar logo asset and adjusted sizing/spacing for the brand mark.
  • Improved mobile menu UX by closing the menu on outside click and after selecting a nav link.
  • Updated Footer logo asset to match the new logo file.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
components/layout/Navbar.tsx Updates logo asset/sizing and improves mobile menu open/close behavior.
components/layout/Footer.tsx Switches footer logo asset to the updated image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ref={mobileToggleRef}
id="nav-mobile-toggle"
className="md:hidden flex items-center justify-center w-8 h-8"
onClick={() => setMobileOpen(!mobileOpen)}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants