Skip to content

Fix cache not resetting when include files are modified#26

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-20
Open

Fix cache not resetting when include files are modified#26
Copilot wants to merge 4 commits intomainfrom
copilot/fix-20

Conversation

Copy link
Copy Markdown

Copilot AI commented May 19, 2025

  • Investigate failing tests
  • Refactor tests to comply with RuboCop style guide
    • Use receive_messages for multiple stubs
    • Add memoized helper for mtime_hash
    • Extract setup to before block
    • Fix line length and formatting issues
  • Verify all tests pass
  • Verify RuboCop only shows pre-existing issues
  • Verify gem builds successfully

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: benbalter <282759+benbalter@users.noreply.github.com>
Copilot AI changed the title [WIP] Cache not resetting/clearing on changes to cached file Fix cache not resetting when include files are modified May 19, 2025
Copilot AI requested a review from benbalter May 19, 2025 18:37
@benbalter benbalter marked this pull request as ready for review May 19, 2025 20:30
@benbalter
Copy link
Copy Markdown
Owner

@copilot can you fix the Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not. rubocop error?

Co-authored-by: benbalter <282759+benbalter@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 21, 2025

@copilot can you fix the Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not. rubocop error?

I've fixed the RuboCop error "Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not" in commit 7490f77.

The issue was resolved by:

  1. Adding a local .rubocop_factory_bot.yml configuration file to override the problematic setting
  2. Pinning to a specific compatible version of rubocop-factory_bot (2.23.1) in the Gemfile
  3. Making the RuboCop configuration inherit from both .rubocop_todo.yml and .rubocop_factory_bot.yml

All tests are passing successfully.

@benbalter
Copy link
Copy Markdown
Owner

@copilot fix failing tests

Co-authored-by: benbalter <282759+benbalter@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Jan 15, 2026

@copilot fix failing tests

I've fixed the failing tests in commit 62e0134. The tests were failing due to RuboCop style violations. I refactored the test code to be more concise and comply with the RuboCop style guide. All tests now pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants