Skip to content

fix(build): keep the OCP suppression list in step with the renamed setters #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardladenthin merged 1 commit into from
Sep 1, 2026
Merged

fix(build): keep the OCP suppression list in step with the renamed setters #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions llama/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ SPDX-License-Identifier: MIT

<!--
ModelParameters intentionally types each enum-valued fluent setter
to its specific enum (CacheType, MiroStat, NumaStrategy,
ReasoningFormat, RopeScalingType, GpuSplitMode, TensorReadLazyMode)
to its specific enum (CacheType, FlashAttn, LazyMode, MiroStat,
NumaStrategy, ReasoningFormat, RopeScalingType, GpuSplitMode)
rather than the shared CliArg interface that those enums all
implement. The narrow type is the API contract:

Expand All @@ -80,12 +80,13 @@ SPDX-License-Identifier: MIT
<Or>
<Method name="setCacheTypeK"/>
<Method name="setCacheTypeV"/>
<Method name="setFlashAttn"/>
<Method name="setLazyMode"/>
<Method name="setMirostat"/>
<Method name="setNuma"/>
<Method name="setReasoningFormat"/>
<Method name="setRopeScaling"/>
<Method name="setSplitMode"/>
<Method name="setTensorReadLazy"/>
</Or>
</Match>

Expand Down
Loading