docs: drop finished work from TODO.md - #410
Merged
Merged
Conversation
781 lines, of which 357 recorded work that is done. Removed:
- The whole 'Done (kept for history)' section (154 lines). Git history and
crossrepostatus.md already hold it.
- The entire 'Model-backed tests that the CI-skip fix newly exposed' section.
Every one of its eight bullets was marked [FIXED], [SUPERSEDED] or
[ANSWERED] -- asserted in the script that removed it, not eyeballed -- and
its preamble was diagnostic scaffolding for a closed investigation, down to
a 'four are open' count that had been wrong for a while.
- The ServerMetrics.getCumulativeTimings() entry, which recorded a claim
verified false and a truncation fixed elsewhere.
- The SpotBugs effort=Max/threshold=Low entry (verified still true: llama/pom.xml
carries both, bound to verify).
The four 'see the Done section' cross-references are rewritten rather than left
dangling.
One thing in there was not history and is kept, in CLAUDE.md where guidance
belongs: spotbugs:check binds to verify, so neither mvn test nor mvn package
runs it. That gap reddened main again this week -- the OCP suppression list
names methods by name, so renaming setTensorReadLazy to setLazyMode left a dead
entry while setLazyMode and setFlashAttn went uncovered. CLAUDE.md now carries
the exact command the CI job runs and the rule that renaming an enum-valued
ModelParameters setter means updating that list in the same commit.
bernardladenthin
had a problem deploying
to
maven-central
September 1, 2026 13:31 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
September 1, 2026 13:31 — with
GitHub Actions
Failure
|
Documentation cleanup reviewed. This PR removes completed work from TODO.md and moves SpotBugs guidance to CLAUDE.md. Changes are well-executed:
No issues found. Recommendation: Ready to merge. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
TODO.mdwas 781 lines, of which 357 recorded work that is done. Docs only.- **in it starts with[FIXED],[SUPERSEDED]or[ANSWERED].What went
## Done (kept for history)### Model-backed tests that the CI-skip fix newly exposed (b10618 PR #403)— all 8 bullets resolvedServerMetrics.getCumulativeTimings()truncation — a claim verified false, with the real fix landed elsewhereeffort=Max+threshold=Low— re-checked:llama/pom.xmlcarries both, bound toverifyThat b10618 section also carried a "How to read the CI evidence" preamble — diagnostic scaffolding for a closed investigation, down to a "two items were fixed, four are open" count that had been wrong for a while. It goes with the section.
The four
see the Done sectioncross-references are rewritten rather than left pointing at nothing.One thing in there was not history, and it is kept
The SpotBugs entry ended with a live warning:
spotbugs:checkbinds toverify, so neithermvn testnormvn packageruns it.That gap reddened
mainthis week. The design-intentOCP_OVERLY_CONCRETE_PARAMETERsuppression inllama/spotbugs-exclude.xmllists methods by name, so renamingsetTensorReadLazytosetLazyModein #408 left a dead entry while the newsetLazyModeandsetFlashAttnwere never covered — #408 passed every local gate and still broke the pipeline (fixed in #409).So the warning moves into
CLAUDE.md, where guidance for working in this repo belongs, with the exact command the failing CI job runs and the rule that renaming or adding an enum-valuedModelParameterssetter means updating that suppression list in the same commit — the same "FQN not updated after a rename" class as the stale PITtargetClassesandCMakeLists.txtOSInfo repairs.Test plan
[FIXED]/[SUPERSEDED]/[ANSWERED]by the script, not by eyeDone sectionreferences left (asserted after rewriting)TODO.md+CLAUDE.mdonly — no source, test or build file touchedRelated issues / PRs
Follows #409. Part of a four-repo pass; siblings are the matching
claude/todo-cleanupbranches inBitcoinAddressFinder,srcmorphandstreambuffer.Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdGenerated by Claude Code