Skip to content

docs: drop finished work from TODO.md - #410

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/todo-cleanup
Sep 1, 2026
Merged

docs: drop finished work from TODO.md#410
bernardladenthin merged 1 commit into
mainfrom
claude/todo-cleanup

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • TODO.md was 781 lines, of which 357 recorded work that is done. Docs only.
  • The largest removal is a whole section whose every bullet was already marked resolved — and that is asserted, not assumed: the script refuses to cut the section unless every - ** in it starts with [FIXED], [SUPERSEDED] or [ANSWERED].

What went

Block Lines
## Done (kept for history) 154
### Model-backed tests that the CI-skip fix newly exposed (b10618 PR #403) — all 8 bullets resolved ~180
ServerMetrics.getCumulativeTimings() truncation — a claim verified false, with the real fix landed elsewhere 10
SpotBugs effort=Max + threshold=Low — re-checked: llama/pom.xml carries both, bound to verify 10

That b10618 section also carried a "How to read the CI evidence" preamble — diagnostic scaffolding for a closed investigation, down to a "two items were fixed, four are open" count that had been wrong for a while. It goes with the section.

The four see the Done section cross-references are rewritten rather than left pointing at nothing.

One thing in there was not history, and it is kept

The SpotBugs entry ended with a live warning: spotbugs:check binds to verify, so neither mvn test nor mvn package runs it.

That gap reddened main this week. The design-intent OCP_OVERLY_CONCRETE_PARAMETER suppression in llama/spotbugs-exclude.xml lists methods by name, so renaming setTensorReadLazy to setLazyMode in #408 left a dead entry while the new setLazyMode and setFlashAttn were never covered — #408 passed every local gate and still broke the pipeline (fixed in #409).

So the warning moves into CLAUDE.md, where guidance for working in this repo belongs, with the exact command the failing CI job runs and the rule that renaming or adding an enum-valued ModelParameters setter means updating that suppression list in the same commit — the same "FQN not updated after a rename" class as the stale PIT targetClasses and CMakeLists.txt OSInfo repairs.

Test plan

  • Every removed bullet asserted to carry [FIXED] / [SUPERSEDED] / [ANSWERED] by the script, not by eye
  • No dangling Done section references left (asserted after rewriting)
  • Remaining structure reviewed section by section: all 50 surviving bullets are genuinely open work
  • Diff is TODO.md + CLAUDE.md only — no source, test or build file touched
  • CI is green on this branch — docs-only, but let it run

Related issues / PRs

Follows #409. Part of a four-repo pass; siblings are the matching claude/todo-cleanup branches in BitcoinAddressFinder, srcmorph and streambuffer.

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes

Generated by Claude Code

781 lines, of which 357 recorded work that is done. Removed:

  - The whole 'Done (kept for history)' section (154 lines). Git history and
    crossrepostatus.md already hold it.
  - The entire 'Model-backed tests that the CI-skip fix newly exposed' section.
    Every one of its eight bullets was marked [FIXED], [SUPERSEDED] or
    [ANSWERED] -- asserted in the script that removed it, not eyeballed -- and
    its preamble was diagnostic scaffolding for a closed investigation, down to
    a 'four are open' count that had been wrong for a while.
  - The ServerMetrics.getCumulativeTimings() entry, which recorded a claim
    verified false and a truncation fixed elsewhere.
  - The SpotBugs effort=Max/threshold=Low entry (verified still true: llama/pom.xml
    carries both, bound to verify).

The four 'see the Done section' cross-references are rewritten rather than left
dangling.

One thing in there was not history and is kept, in CLAUDE.md where guidance
belongs: spotbugs:check binds to verify, so neither mvn test nor mvn package
runs it. That gap reddened main again this week -- the OCP suppression list
names methods by name, so renaming setTensorReadLazy to setLazyMode left a dead
entry while setLazyMode and setFlashAttn went uncovered. CLAUDE.md now carries
the exact command the CI job runs and the rule that renaming an enum-valued
ModelParameters setter means updating that list in the same commit.
@claude

claude Bot commented Sep 1, 2026

Copy link
Copy Markdown

Documentation cleanup reviewed. This PR removes completed work from TODO.md and moves SpotBugs guidance to CLAUDE.md. Changes are well-executed:

  • Script-driven validation ensures only completed items were removed
  • SpotBugs guidance appropriately moved to CLAUDE.md for developer reference
  • All cross-references updated correctly
  • Documentation-only changes (no source code modifications)
  • spotbugs-exclude.xml exists and is referenced correctly

No issues found. Recommendation: Ready to merge.

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@bernardladenthin
bernardladenthin merged commit 519ff86 into main Sep 1, 2026
14 of 17 checks passed
@bernardladenthin
bernardladenthin deleted the claude/todo-cleanup branch September 1, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants