Skip to content

fix(build): make srcmorph/pom.xml parseable again - #200

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/fix-pom-xml-comment
Sep 1, 2026
Merged

fix(build): make srcmorph/pom.xml parseable again#200
bernardladenthin merged 1 commit into
mainfrom
claude/fix-pom-xml-comment

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • main does not build at all, and not for the reason everyone assumes. The known blocker is the unpublished net.ladenthin:llama:5.2.0. But Maven never gets that far — it cannot read the project:
    Non-parseable POM .../srcmorph/pom.xml: in comment after two dashes (--)
    next character must be > not f (position: END_TAG seen ... (--f... @54:73)
    
  • XML forbids -- inside a comment. The llama.version rationale added in 5b4abeb spelled the CLI flags with their leading dashes (--flash-attn, --tensor-read-lazy, --lazy-mode) and used a двух-hyphen dash as punctuation — four occurrences in one comment block. Every goal fails before dependency resolution, which is exactly why this hid behind the expected 5.2.0 failure instead of standing out.
  • The flags are named without their leading dashes and the punctuation dash becomes a semicolon. No wording is lost.

How it got in

5b4abeb edited a POM and was pushed without running a single Maven command against it. The subsequent test runs all happened on a branch that predated that commit, so nothing on my side ever loaded the broken file. Worth naming plainly: this is not a subtle failure mode, it is a skipped check.

Test plan

  • All four reactor POMs verified to contain no -- inside any <!-- --> block — by a regex over every comment, not by eye
  • srcmorph/pom.xml parses under a strict XML parser (xml.dom.minidom), which is what rejected it before
  • mvn validate exits 0 (it previously died in project construction)
  • CI is green on this branch — the 5.2.0 dependency is still unpublished, so the build will still fail later, at resolution. That is the pre-existing blocker this PR does not claim to fix; what changes is that Maven now reaches it.

Related issues / PRs

Fixes the POM introduced by #198. Independent of, and a prerequisite for, #199.

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes

Generated by Claude Code

main does not build at all -- not because of the unpublished 5.2.0 dependency,
but because the POM is not well-formed XML:

  Non-parseable POM .../srcmorph/pom.xml: in comment after two dashes (--)
  next character must be > not f (position: END_TAG seen ... (--f... @54:73)

XML forbids '--' inside a comment. The llama.version rationale I added in
5b4abeb spelled the CLI flags with their leading dashes (--flash-attn,
--tensor-read-lazy, --lazy-mode) and used an em-dash-as-two-hyphens, four
occurrences in one comment block. Maven cannot even read the project, so every
goal fails before dependency resolution is reached -- which is why this hid
behind the expected 5.2.0 failure.

The flags are named without the leading dashes and the punctuation dash is
replaced by a semicolon; no wording is lost.

Verified: all four reactor POMs now have no '--' inside any comment (checked by
regex over every <!-- --> block, not by eye), the file parses under a strict XML
parser, and 'mvn validate' exits 0.

My own miss: 5b4abeb edited a POM and I pushed it without running a single
Maven command against it.
@claude

claude Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review

Fix is correct and well-executed.

What was fixed

  • Removed -- sequences inside XML comments that violated XML specification
  • Changed --flash-attn, --tensor-read-lazy, --lazy-mode to flag names without leading dashes
  • Replaced an em-dash (represented as --) with a semicolon for punctuation
  • No code or configuration changes—only comment text modified

Verification

  • Changes are minimal, surgical, and confined to comment blocks only
  • Semantic meaning preserved (flag names still clearly referenced)
  • Per the PR description, regex verification confirms no remaining invalid -- patterns in any reactor POM

Assessment

This fixes a critical blocker—the POM was unparseable XML, preventing even mvn validate from succeeding. The fix is low-risk since it only affects documentation comments, not build configuration or code.

The root cause (pushing POM changes without running mvn validate first) is acknowledged in the commit message.

@bernardladenthin
bernardladenthin merged commit 9b4ecf9 into main Sep 1, 2026
19 of 27 checks passed
@bernardladenthin
bernardladenthin deleted the claude/fix-pom-xml-comment branch September 1, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants