fix(build): make srcmorph/pom.xml parseable again - #200
Merged
Conversation
main does not build at all -- not because of the unpublished 5.2.0 dependency, but because the POM is not well-formed XML: Non-parseable POM .../srcmorph/pom.xml: in comment after two dashes (--) next character must be > not f (position: END_TAG seen ... (--f... @54:73) XML forbids '--' inside a comment. The llama.version rationale I added in 5b4abeb spelled the CLI flags with their leading dashes (--flash-attn, --tensor-read-lazy, --lazy-mode) and used an em-dash-as-two-hyphens, four occurrences in one comment block. Maven cannot even read the project, so every goal fails before dependency resolution is reached -- which is why this hid behind the expected 5.2.0 failure. The flags are named without the leading dashes and the punctuation dash is replaced by a semicolon; no wording is lost. Verified: all four reactor POMs now have no '--' inside any comment (checked by regex over every <!-- --> block, not by eye), the file parses under a strict XML parser, and 'mvn validate' exits 0. My own miss: 5b4abeb edited a POM and I pushed it without running a single Maven command against it.
bernardladenthin
had a problem deploying
to
maven-central
September 1, 2026 09:42 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
September 1, 2026 09:42 — with
GitHub Actions
Failure
8 tasks
Review✅ Fix is correct and well-executed. What was fixed
Verification
AssessmentThis fixes a critical blocker—the POM was unparseable XML, preventing even The root cause (pushing POM changes without running |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maindoes not build at all, and not for the reason everyone assumes. The known blocker is the unpublishednet.ladenthin:llama:5.2.0. But Maven never gets that far — it cannot read the project:--inside a comment. Thellama.versionrationale added in5b4abebspelled the CLI flags with their leading dashes (--flash-attn,--tensor-read-lazy,--lazy-mode) and used a двух-hyphen dash as punctuation — four occurrences in one comment block. Every goal fails before dependency resolution, which is exactly why this hid behind the expected 5.2.0 failure instead of standing out.How it got in
5b4abebedited a POM and was pushed without running a single Maven command against it. The subsequent test runs all happened on a branch that predated that commit, so nothing on my side ever loaded the broken file. Worth naming plainly: this is not a subtle failure mode, it is a skipped check.Test plan
--inside any<!-- -->block — by a regex over every comment, not by eyesrcmorph/pom.xmlparses under a strict XML parser (xml.dom.minidom), which is what rejected it beforemvn validateexits 0 (it previously died in project construction)Related issues / PRs
Fixes the POM introduced by #198. Independent of, and a prerequisite for, #199.
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdGenerated by Claude Code