style: apply spotless to the enable_thinking and calibrate changes - #203
Conversation
main fails 'mvn verify' at spotless:check. Five files carry violations, from both #199 (the getter rename lengthened lines past the wrap point) and #202 (the new renderers). Same root cause as the SpotBugs failure fixed in java-llama.cpp#409, in the same week: spotless:check binds to a phase that 'mvn test' never reaches, so a change validated with tests -- even with tests plus a full PIT run, as #202 was -- can still be unformatted. Running the goal, not more tests, is what catches this. Formatting only: no logic, no assertion, no test changed. Produced by 'mvn spotless:apply' rather than by hand, after a hand-wrap of the same line was itself rejected by spotless:check -- the tool decides the layout, not me. Verified: 'mvn -f srcmorph/pom.xml spotless:check' exits 0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH
Code Review Summary✅ Approved — This PR contains formatting-only changes with no logic, assertions, or test modifications. Review FindingsCode Quality: ✅ No issues
Security: ✅ No issues
Architecture & Design: ✅ Compliant
Context ValidationThe root-cause analysis in the PR description is correct: Files ReviewedAll 5 files contain only line wrapping/joining adjustments:
✅ Ready to merge once CI gates pass. |
Summary
mainfailsmvn verifyatspotless:check. Five files carry format violations, from both feat!: send enable_thinking only when it was actually set #199 (theisChatTemplateEnableThinking→getChatTemplateEnableThinkingrename pushed lines past the wrap point) and feat: write the calibration report as JSON and YAML #202 (the new renderers).mvn spotless:apply, not by hand. My own hand-wrap of the same line was rejected byspotless:checkon the next run, which is the argument for letting the tool decide the layout.Why it got through twice
spotless:checkbinds to a phasemvn testnever reaches. #202 was validated with a full reactor test run and a complete PIT pass atmutationThreshold100 across all three modules — and still shipped unformatted, because none of that runs the goal.This is the same failure mode as the SpotBugs breakage in java-llama.cpp#409 this week: a gate bound past
test, a local loop that stops attest, and a green-looking change that reddensmain. More tests do not close it; running the goal does.Test plan
mvn -o -f srcmorph/pom.xml spotless:checkexits 0 (was exit 1 naming five files)mainpins the unpublishednet.ladenthin:llama:5.2.0, so every srcmorph PR still fails at dependency resolution. Unrelated to this change.Related issues / PRs
Fixes formatting introduced by #199 and #202.
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.md🤖 Generated with Claude Code
https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH
Generated by Claude Code