Skip to content

build(deps): bump build plugins and analysis tooling to current - #155

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/dep-bumps-2026-09
Sep 5, 2026
Merged

build(deps): bump build plugins and analysis tooling to current#155
bernardladenthin merged 1 commit into
mainfrom
claude/dep-bumps-2026-09

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

Pure version maintenance, no behaviour change. One of four coordinated PRs (jllama / srcmorph / BAF / streambuffer).

Cross-repo drift, closed. The four sibling repos deliberately run the same toolchain versions; BitcoinAddressFinder pulled ahead when its Dependabot PRs were merged.

before after
maven-compiler-plugin 3.15.0 3.16.0
maven-surefire-plugin 3.5.6 3.6.0
nullaway 0.14.0 0.14.1

Behind current upstream in all four repos.

before after
git-commit-id-maven-plugin 10.0.0 10.0.1
spotless-maven-plugin 3.10.1 3.10.2
spotbugs-maven-plugin 4.10.4.0 4.10.4.1
checker / checker-qual 4.2.2 4.2.3

No lombok and no slf4j rows here — this repo uses neither.

The checker bump moves one property that feeds both the annotation processor and the qualifiers, and that coupling is the point: the Nullness Checker resolves its own qualifiers through javac's symbol table, so the two must share a major version — the lesson from the 3.55.1 pin reverted in java-llama.cpp.

Deliberately NOT bumped: jqwik stays at 1.9.3. Releases from 1.10.0 on print a prompt-injection string aimed at AI coding agents, and the workspace policy requires rejecting any PR that moves it. Dependabot will keep proposing it.

Test plan

  • mvn clean verify green — 288 tests, 0 failures (includes the jqwik properties and the Lincheck linearizability run)
  • PIT 179/179 mutations killed (100%)
  • Class-file gate clean over target: 500 classes, 0 above major 52
  • spotless 3.10.2 reformats nothing — the working tree after spotless:apply holds only the pom edit
  • CI is green on this branch
  • No source or test change; pom only

Related PRs

Same change in java-llama.cpp, srcmorph and BitcoinAddressFinder (category 2 only — BAF already carries category 1).

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes

🤖 Generated with Claude Code

https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH


Generated by Claude Code

Pure version maintenance, no behaviour change. Two groups:

Cross-repo drift, closed. The four sibling repos deliberately run the same
toolchain versions, and BitcoinAddressFinder pulled ahead when its Dependabot
PRs were merged. This brings the rest back in step:

  maven-compiler-plugin  3.15.0  -> 3.16.0
  maven-surefire-plugin  3.5.6   -> 3.6.0
  nullaway               0.14.0  -> 0.14.1

Behind current upstream in all four repos:

  git-commit-id-maven-plugin  10.0.0    -> 10.0.1
  spotless-maven-plugin       3.10.1    -> 3.10.2
  spotbugs-maven-plugin       4.10.4.0  -> 4.10.4.1
  checker / checker-qual      4.2.2     -> 4.2.3

Note the checker bump moves ONE property that feeds both the annotation
processor and the qualifiers. That is deliberate and must stay that way:
the Nullness Checker resolves its own qualifiers through javac's symbol
table, so processor and checker-qual have to share a major version -- the
lesson from the reverted 3.55.1 pin in java-llama.cpp.

Deliberately NOT bumped: jqwik stays at 1.9.3. Releases from 1.10.0 on print
a prompt-injection string aimed at AI coding agents, and the workspace policy
(policies/jqwik-prompt-injection.md) requires rejecting any PR that moves it.
Dependabot will keep proposing it.

Verified locally: mvn clean verify green (288 tests), PIT 179/179 mutations
killed (100%), the class-file gate clean over target (500 classes, 0 above
major 52), and spotless 3.10.2 reformats nothing -- the working tree after
`spotless:apply` holds only the pom edit itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH
@claude

claude Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Summary

This is a well-structured dependency maintenance PR. The changes are limited to version updates in pom.xml with clear, deliberate reasoning.

✅ Strengths

  1. Pure maintenance scope — Only version updates, no source/test changes minimizes risk
  2. Thoughtful version pinning — Deliberately excludes jqwik 1.10.0+ with documented reasoning (prompt-injection concern per workspace policy)
  3. Critical detail on checker — Correctly identifies that checker and checker-qual must share major versions due to javac symbol table resolution coupling
  4. Coordinated across repos — Part of deliberate effort to keep toolchain versions aligned across 4 sibling repos
  5. Comprehensive verification — Claims are backed by local testing:
    • All 288 tests pass (including jqwik properties and Lincheck linearizability tests)
    • PIT mutation testing: 179/179 mutations killed (100%)
    • Bytecode version gate: 500 classes, all ≤ major 52
    • Spotless formatting: no unexpected changes
  6. Clear changelog — PR description clearly categorizes updates
  7. Follows conventions — Conventional Commits format (build(deps): ...), has read CONTRIBUTING.md

Patch updates (low risk)

  • nullaway: 0.14.0 → 0.14.1
  • checker/checker-qual: 4.2.2 → 4.2.3
  • spotless-maven-plugin: 3.10.1 → 3.10.2
  • spotbugs-maven-plugin: 4.10.4.0 → 4.10.4.1
  • git-commit-id-maven-plugin: 10.0.0 → 10.0.1

Minor updates (still low risk for build tooling)

  • maven-compiler-plugin: 3.15.0 → 3.16.0
  • maven-surefire-plugin: 3.5.6 → 3.6.0

Deliberately NOT updated

  • jqwik: remains at 1.9.3 per workspace policy

Ready to merge — High-quality maintenance PR with sound reasoning and comprehensive verification.

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.88%. Comparing base (86a4ae0) to head (04fd290).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #155   +/-   ##
=========================================
  Coverage     96.88%   96.88%           
  Complexity       94       94           
=========================================
  Files             1        1           
  Lines           257      257           
  Branches         33       33           
=========================================
  Hits            249      249           
  Misses            2        2           
  Partials          6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 99.222%. remained the same — claude/dep-bumps-2026-09 into main

@bernardladenthin
bernardladenthin merged commit 0442112 into main Sep 5, 2026
28 of 30 checks passed
@bernardladenthin
bernardladenthin deleted the claude/dep-bumps-2026-09 branch September 5, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants